Added Vertex AI spans for request parameters #3192
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72a92bb to
105cf3c
Compare
8e8effb to
76887e9
Compare
aabmass
commented
Jan 16, 2025
| GenAIAttributes.GEN_AI_REQUEST_FREQUENCY_PENALTY: generation_config.get( | ||
| "frequency_penalty" | ||
| ), | ||
| GenAIAttributes.GEN_AI_OPENAI_REQUEST_SEED: generation_config.get( |
There was a problem hiding this comment.
Vertex also has seed–"random seed for generation".
Should we promote this to a general attribute? @lmolkova
76887e9 to
73cfcda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3041, follow up to #3123.
Adds basic tracing instrumentation for Vertex AI. Right now, it supports only request span attributes–I will add response attributes and content logging in later PR(s). I also added VCR tests with proper sanitization.
In the end, I didn't copy any code from OpenLLMetry and mostly adapted from openai-v2. Also the code is typed 😃
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.