Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 561 to opentelemetry-instrumentation-wsgi #3129

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

Kludex
Copy link
Contributor

@Kludex Kludex commented Dec 20, 2024

No description provided.

@Kludex Kludex requested a review from a team as a code owner December 20, 2024 18:43
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume we should put this on hold until the instrumentation failing at CI gets fixed with the from __future__ import annotations right?

@Kludex
Copy link
Contributor Author

Kludex commented Jan 2, 2025

Oh, I forgot to push... Give me a sec.

@Kludex Kludex force-pushed the kludex/types-wsgi branch from 85ef682 to 6c75215 Compare January 2, 2025 16:43
@Kludex Kludex requested a review from emdneto January 2, 2025 16:45
@Kludex
Copy link
Contributor Author

Kludex commented Jan 2, 2025

It should be fine now. cc @emdneto

@lzchen lzchen merged commit 5219242 into open-telemetry:main Jan 13, 2025
675 checks passed
@Kludex Kludex deleted the kludex/types-wsgi branch January 14, 2025 09:06
xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants