Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement mutable ReadWriteLogRecord #1482

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 21, 2025

open-telemetry/opentelemetry-specification#3907 implements some new requirements for logging:

  • ReadWriteLogRecord can mutate (eg by processors)
  • mutated ReadWriteLogRecord can be seen by later processors

This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference

open-telemetry/opentelemetry-specification#3907 implements some new
requirements for logging:
- ReadWriteLogRecord can mutate (eg by processors)
- mutated ReadWriteLogRecord can be seen by later processors

This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference
@brettmc brettmc added the breaking A breaking change label Jan 21, 2025
@brettmc brettmc requested a review from a team as a code owner January 21, 2025 06:08
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (145b87f) to head (88db93f).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1482      +/-   ##
============================================
+ Coverage     72.20%   72.27%   +0.07%     
- Complexity     2730     2733       +3     
============================================
  Files           401      402       +1     
  Lines          8152     8169      +17     
============================================
+ Hits           5886     5904      +18     
+ Misses         2266     2265       -1     
Flag Coverage Δ
8.2 72.21% <100.00%> (+0.05%) ⬆️
8.3 72.22% <100.00%> (+0.11%) ⬆️
8.4 72.16% <100.00%> (+0.02%) ⬆️
8.5 72.19% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Logs/Exporter/InMemoryExporter.php 100.00% <100.00%> (ø)
src/SDK/Logs/Processor/BatchLogRecordProcessor.php 100.00% <100.00%> (ø)
src/SDK/Logs/Processor/MultiLogRecordProcessor.php 100.00% <100.00%> (ø)
src/SDK/Logs/Processor/NoopLogRecordProcessor.php 100.00% <ø> (ø)
...rc/SDK/Logs/Processor/SimpleLogRecordProcessor.php 100.00% <100.00%> (ø)
src/SDK/Logs/ReadWriteLogRecord.php 100.00% <100.00%> (ø)
src/SDK/Logs/ReadableLogRecord.php 94.11% <100.00%> (-0.17%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145b87f...88db93f. Read the comment docs.

Copy link
Collaborator

@bobstrecansky bobstrecansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change to me. We should chat about the breaking change tomorrow in the SIG meeting.

@bobstrecansky
Copy link
Collaborator

Ahh, darn it - we didn't talk about this in the SIG meeting. Let's chat about it.

@brettmc brettmc merged commit 27dfc42 into open-telemetry:2.x Jan 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants