-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement mutable ReadWriteLogRecord #1482
implement mutable ReadWriteLogRecord #1482
Conversation
open-telemetry/opentelemetry-specification#3907 implements some new requirements for logging: - ReadWriteLogRecord can mutate (eg by processors) - mutated ReadWriteLogRecord can be seen by later processors This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1482 +/- ##
============================================
+ Coverage 72.20% 72.27% +0.07%
- Complexity 2730 2733 +3
============================================
Files 401 402 +1
Lines 8152 8169 +17
============================================
+ Hits 5886 5904 +18
+ Misses 2266 2265 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable change to me. We should chat about the breaking change tomorrow in the SIG meeting.
Ahh, darn it - we didn't talk about this in the SIG meeting. Let's chat about it. |
open-telemetry/opentelemetry-specification#3907 implements some new requirements for logging:
This is a breaking change because LogRecordProcessorInterface onEmit param changes to by-reference