Fix error when the operator metrics ServiceMonitor already exists #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <iblancas@redhat.com>
swiatekm
reviewed
Nov 11, 2024
added 2 commits
November 11, 2024 16:20
Signed-off-by: Israel Blancas <iblancas@redhat.com>
swiatekm
approved these changes
Nov 11, 2024
pavolloffay
approved these changes
Nov 12, 2024
|
Hi @pavolloffay, can we get this in a patch release sometime soon ? we're forced to use a main build now. |
|
@vladst3f we're going to be releasing v0.114.0 shortly. We'll also discuss whether this warrants releasing a patch for 0.113.0 in addition. Apologies for the hassle! |
|
cheers, most likely rolling forward will go down smoothly. the quick reaction is appreciated! |
|
This has been broken for two weeks now and should have been a patch to 0.113 once this pr was landed and not waiting the full length for a new release imho |
swiatekm
pushed a commit
to swiatekm/opentelemetry-operator
that referenced
this pull request
Nov 27, 2024
…en-telemetry#3447) * Fix error when the operator metrics ServiceMonitor already exists Signed-off-by: Israel Blancas <iblancas@redhat.com> * Wrap the errors and log them Signed-off-by: Israel Blancas <iblancas@redhat.com> --------- Signed-off-by: Israel Blancas <iblancas@redhat.com> (cherry picked from commit 917b096)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: @IshwarKanse is working on a test to ensure this is detected in early stages.