-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoinstrumentation] Add node and pod ip env vars automatically #2769
Changes from 6 commits
0725566
57c7ebd
375b259
8b2ef8c
2839012
a47c8e7
d6d2245
dcf3579
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action) | ||
component: instrumentation | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Add node and pod ips as env vars automatically | ||
|
||
# One or more tracking issues related to the change | ||
issues: [2769] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,9 @@ const ( | |
|
||
EnvPodName = "OTEL_RESOURCE_ATTRIBUTES_POD_NAME" | ||
EnvPodUID = "OTEL_RESOURCE_ATTRIBUTES_POD_UID" | ||
EnvPodIP = "OTEL_POD_IP" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there an attribute name in the spec for the POD and NODE IPs? we should consider putting these under There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I opted not to use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For semantic convention, there isn't a |
||
EnvNodeName = "OTEL_RESOURCE_ATTRIBUTES_NODE_NAME" | ||
EnvNodeIP = "OTEL_NODE_IP" | ||
|
||
FlagApacheHttpd = "enable-apache-httpd-instrumentation" | ||
FlagDotNet = "enable-dotnet-instrumentation" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we list the env vars here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated