Add logging for prometheus operator in TargetAllocator's config generator #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
approved these changes
Nov 9, 2023
|
How busy were the logs when you enabled this? could you add some samples ones to the PR description? |
Thanks @jaronoff97. The logs were not busy. Since it is mostly only for invalid cases like the one in the description. Please help with merging this PR if all looks good. |
frzifus
approved these changes
Nov 10, 2023
…hmichandrashekar/opentelemetry-operator into rashmi/prom-operator-logging
|
@jaronoff97 @frzifus - Please help get this merged, as I dont have permissions. Thanks! |
|
LGTM @jaronoff97 has to click :) |
|
Sorry I am on PTO today, but can merge real quick :) |
Thanks so much @jaronoff97! |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…ator (open-telemetry#2329) * add logging for prometheus operator * adding yaml for changelog * Adding tracking issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - Currently, the prometheus operator logs, if any, are not visible from the targetallocator. This change enables error logging from prometheus-operator
Testing: Tested that logs that are returned by prometheus operator are logged to stdout
Sample logs -