Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot grouping for common things #1979

Merged
merged 3 commits into from
Aug 3, 2023
+40 −0
Merged

Add dependabot grouping for common things #1979

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aa2119
Add groups
jaronoff97 Aug 2, 2023
39ea5e0
add chlog entry
jaronoff97 Aug 2, 2023
c975633
remove chloggen
jaronoff97 Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,54 @@ updates:
directory: /
schedule:
interval: daily
# Create a group of dependencies to be updated together in one pull request
groups:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a wildcard (*) be added in some group? I think this means you will miss grouped updates for any dependency does not match one of the patterns below.

Is that intentional? The docs aren't clear how the grouped updates will behave if a dependency matches a pattern in multiple groups. Or I missed it, which happens.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this more. You could probably get a little complicated here by having a wildcard group that has an exclude pattern for all the other patterns listed earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean... here's an example of what sarama does https://github.com/IBM/sarama/blob/c10bd1e5709a7b47729b445bc98f2e41bc7cc0a8/.github/dependabot.yml#L27

Copy link
Contributor

@bryan-aguilar bryan-aguilar Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1807

I think what I am getting at is dependencies such as github.com/stretchr/testify and github.com/gin-gonic/gin will not be matched into any group right? So this means we will still see one off PRs raised for these. That could be completely intentional, but the goal wasn't clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the PR title says common things and not everything. So looks good to me! Just adding some food for thought.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah very intentional. I took a list of all the things I most frequently have to update and just did some grouping on those

golang-org-x:
patterns:
- "golang.org/x/*"
prometheus:
patterns:
- "github.com/prometheus-operator/prometheus-operator/*"
- "github.com/prometheus/prometheus/*"
- "github.com/prometheus/client_go/*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
- package-ecosystem: gomod
directory: /cmd/operator-opamp-bridge
schedule:
interval: daily
groups:
golang-org-x:
patterns:
- "golang.org/x/*"
prometheus:
patterns:
- "github.com/prometheus-operator/prometheus-operator/*"
- "github.com/prometheus/prometheus/*"
- "github.com/prometheus/client_go/*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"
- package-ecosystem: gomod
directory: /cmd/otel-allocator
schedule:
interval: daily
groups:
golang-org-x:
patterns:
- "golang.org/x/*"
prometheus:
patterns:
- "github.com/prometheus-operator/prometheus-operator/*"
- "github.com/prometheus/prometheus/*"
- "github.com/prometheus/client_go/*"
kubernetes:
patterns:
- "k8s.io/*"
- "sigs.k8s.io/*"

- package-ecosystem: github-actions
directory: /
Expand Down