Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the monitoring port depending on the configuration #1950

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Expose the monitoring port depending on the configuration #1950

merged 4 commits into from
Jul 24, 2023

Conversation

iblancasa
Copy link
Contributor

Resolves #1931

iblancasa added 2 commits July 21, 2023 12:34
@iblancasa
Create the monitoring service using the port specified by the user
52369bc 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Add missing changelog
7fab306 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested a review from a team July 21, 2023 11:07
TylerHelmuth
TylerHelmuth approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jaronoff97
Copy link
Contributor

Great enhancement, thank you!

@jaronoff97 jaronoff97 merged commit 9e7fe16 into open-telemetry:main Jul 24, 2023
@iblancasa iblancasa deleted the task/1931 branch July 24, 2023 15:39
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@iblancasa
Expose the monitoring port depending on the configuration (open-telem…
bd50400 
…etry#1950)

* Create the monitoring service using the port specified by the user

Signed-off-by: Israel Blancas <iblancasa@gmail.com>

* Add missing changelog

Signed-off-by: Israel Blancas <iblancasa@gmail.com>

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@frzifus frzifus frzifus approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose the metrics port according to the OTEL Collector config
4 participants
@iblancasa @jaronoff97 @frzifus @TylerHelmuth