Fix getPrometheusExporterPorts incorrectly matching to prometheusremo…

…tewrite exporter (#2016) (#2017)

* Fix getPrometheusExporterPorts incorrectly matching to prometheusremotewrite exporter

* add unit test for collector prometheus rw exporter

* standardized code format

internal/manifests/collector/container.go

@@ -220,7 +220,8 @@ func getPrometheusExporterPorts(c map[interface{}]interface{}) ([]corev1.Contain
 	if exporters, ok := c["exporters"]; ok && exporters != nil {
 		for e, exporterConfig := range exporters.(map[interface{}]interface{}) {
 			exporterName := e.(string)
-			if strings.Contains(exporterName, "prometheus") {
+			// Note that receivers, processors, exporters and/or pipelines are defined via component identifiers in type[/name] format (e.g. otlp or otlp/2). Components of a given type can be defined more than once as long as the identifiers are unique.
+			if strings.Split(exporterName, "/")[0] == "prometheus" {
 				containerPort, err := getPrometheusExporterPort(exporterConfig.(map[interface{}]interface{}))
 				if err != nil {
 					errors = append(errors,

internal/manifests/collector/container_test.go

@@ -214,6 +214,38 @@ service:
 				},
 			},
 		},
+		{
+			description: "prometheus RW exporter",
+			specConfig: `exporters:
+    prometheusremotewrite/prometheus:
+        endpoint: http://prometheus-server.monitoring/api/v1/write`,
+			specPorts:     []corev1.ServicePort{},
+			expectedPorts: []corev1.ContainerPort{metricContainerPort},
+		},
+		{
+			description: "multiple prometheus exporters and prometheus RW exporter",
+			specConfig: `exporters:
+    prometheus/prod:
+        endpoint: "0.0.0.0:9090"
+    prometheus/dev:
+        endpoint: "0.0.0.0:9091"
+    prometheusremotewrite/prometheus:
+        endpoint: http://prometheus-server.monitoring/api/v1/write`,
+			specPorts: []corev1.ServicePort{},
+			expectedPorts: []corev1.ContainerPort{
+				metricContainerPort,
+				{
+					Name:          "prometheus-prod",
+					ContainerPort: 9090,
+					Protocol:      corev1.ProtocolTCP,
+				},
+				{
+					Name:          "prometheus-dev",
+					ContainerPort: 9091,
+					Protocol:      corev1.ProtocolTCP,
+				},
+			},
+		},
 	}
 
 	for _, testCase := range tests {