This repository has been archived by the owner on May 25, 2022. It is now read-only.
UDP / TCP input: check for nil interface before calling Close() #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
=======================================
+ Coverage 76.4% 76.6% +0.2%
=======================================
Files 95 95
Lines 4454 4456 +2
=======================================
+ Hits 3404 3416 +12
+ Misses 719 714 -5
+ Partials 331 326 -5
|
djaglowski
approved these changes
Sep 27, 2021
djaglowski
added a commit
to djaglowski/opentelemetry-log-collection
that referenced
this pull request
Nov 30, 2021
- `combine_with` setting to `recombine` operator, to allow for joining on custom delimiter ([PR315](open-telemetry#315)) - Issue where `force_flush_period` could cause line splitting to be skipped ([PR303](open-telemetry#303)) - Issue where `tcp_input` and `udp_input` could panic when stopping ([PR273](open-telemetry#273)) - Syslog severity mapping is now aligned with log specification ([PR300](open-telemetry#300)) - Improve error message when timezone database is not found ([PR289](open-telemetry#289))
djaglowski
added a commit
that referenced
this pull request
Nov 30, 2021
- `combine_with` setting to `recombine` operator, to allow for joining on custom delimiter ([PR315](#315)) - Issue where `force_flush_period` could cause line splitting to be skipped ([PR303](#303)) - Issue where `tcp_input` and `udp_input` could panic when stopping ([PR273](#273)) - Syslog severity mapping is now aligned with log specification ([PR300](#300)) - Improve error message when timezone database is not found ([PR289](#289))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #272