-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collector): add manual collector build workflow #1661
feat(collector): add manual collector build workflow #1661
Conversation
ac8fdcd
to
065b9ba
Compare
name: "Manual Build (Collector)" | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks useful. I assume this can be run on any arbitrary fork/branch. I suggest updating the collector documentation to highlight this as a way to build a custom layer. Even better if you can include documentation for how to manually upload the layer to an account. These are optional suggestions though and can be done later if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to enhance this workflow (for ex. specifying build tags so custom collector binary will be able to built, deploying as layer to the specified AWS account, etc ...).
So I think, it is better to merge this as is into the main branch and then I can test in in my fork/branch for the further enhancements easier. And then, I will add the final documentation based on those.
065b9ba
to
da7a21f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the following criteria:
- Please update the description.
- Remember to follow up with updated documentation later on.
@tylerbenson I will add documentation in the next PR along with enhancements, but didn't understand updating the description. Is it for this PR? |
Yes, this PR has an empty description. Please populate with some details describing the motivation for this. |
@tylerbenson Added description. Please check. |
Ok, then merging and will come with follow-up PR(s) for the enhancements soon. |
The motivation of this PR is being able to build collector binaries from working branches.
For example, if you don't have a local environment to produce Lambda collector binaries for both
amd64
and/orarm64
architectures to test in the real Lambda environment, you can use this workflow in your own fork/branch to build your custom collector binaries.In the later PRs, this workflow will be enhanced by supporting