Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collector): add manual collector build workflow #1661

Conversation

serkan-ozal
Copy link
Contributor

@serkan-ozal serkan-ozal commented Jan 14, 2025

The motivation of this PR is being able to build collector binaries from working branches.

For example, if you don't have a local environment to produce Lambda collector binaries for both amd64 and/or arm64 architectures to test in the real Lambda environment, you can use this workflow in your own fork/branch to build your custom collector binaries.

In the later PRs, this workflow will be enhanced by supporting

  • build tags, so custom collector binary will be able to built
  • deploying as layer to the specified AWS account
  • etc ...

@serkan-ozal serkan-ozal requested a review from a team as a code owner January 14, 2025 17:39
@serkan-ozal serkan-ozal force-pushed the feat/collector/manual-collector-build branch from ac8fdcd to 065b9ba Compare January 14, 2025 17:52
name: "Manual Build (Collector)"

on:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful. I assume this can be run on any arbitrary fork/branch. I suggest updating the collector documentation to highlight this as a way to build a custom layer. Even better if you can include documentation for how to manually upload the layer to an account. These are optional suggestions though and can be done later if you prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerbenson

I am planning to enhance this workflow (for ex. specifying build tags so custom collector binary will be able to built, deploying as layer to the specified AWS account, etc ...).

So I think, it is better to merge this as is into the main branch and then I can test in in my fork/branch for the further enhancements easier. And then, I will add the final documentation based on those.

@serkan-ozal serkan-ozal force-pushed the feat/collector/manual-collector-build branch from 065b9ba to da7a21f Compare January 14, 2025 19:08
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the following criteria:

  • Please update the description.
  • Remember to follow up with updated documentation later on.

@serkan-ozal
Copy link
Contributor Author

Approving with the following criteria:

  • Please update the description.
  • Remember to follow up with updated documentation later on.

@tylerbenson I will add documentation in the next PR along with enhancements, but didn't understand updating the description. Is it for this PR?

@tylerbenson
Copy link
Member

Yes, this PR has an empty description. Please populate with some details describing the motivation for this.

@serkan-ozal
Copy link
Contributor Author

Yes, this PR has an empty description. Please populate with some details describing the motivation for this.

@tylerbenson Added description. Please check.

@serkan-ozal
Copy link
Contributor Author

Ok, then merging and will come with follow-up PR(s) for the enhancements soon.

@serkan-ozal serkan-ozal merged commit e1d2c21 into open-telemetry:main Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants