Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodejs): add ability to be able to enable/disable active instrumentations by env var #1653

Conversation

serkan-ozal
Copy link
Contributor

No description provided.

@serkan-ozal serkan-ozal requested a review from a team as a code owner January 10, 2025 13:39
@RaphaelManke
Copy link

RaphaelManke commented Jan 10, 2025

I like the idea to give more control of what is loaded and what not.

This change seems to introduce a configuration option (unless it's just something experimental/internal right now) and therefore should have a documentation section in the readme.

@serkan-ozal
Copy link
Contributor Author

serkan-ozal commented Jan 10, 2025

These configurations are already in use ones as mentioned here: https://opentelemetry.io/docs/zero-code/js/configuration/#excluding-instrumentation-libraries

@serkan-ozal serkan-ozal force-pushed the feat/nodejs/enable-disable-instrumentations branch 2 times, most recently from 6a87508 to 9a82902 Compare January 13, 2025 17:26
@tylerbenson
Copy link
Member

It looks like Node already follows this convention, so that's fine. Just pointing it out that Java does it a bit differently: https://opentelemetry.io/docs/zero-code/java/agent/disable/#enable-only-specific-instrumentation

Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me.

@serkan-ozal serkan-ozal force-pushed the feat/nodejs/enable-disable-instrumentations branch from 9a82902 to af819a8 Compare January 14, 2025 17:53
@serkan-ozal serkan-ozal merged commit 506ebea into open-telemetry:main Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants