Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-mongodb-core): add missing codecov script #601

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Add missing codecov script

  • Bump up @opentelemetry/node => ^0.2.0

  • Bump up @opentelemetry/tracing => ^0.2.0

@mayurkale22
Copy link
Member Author

/cc @vmarchaud

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #601 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   90.43%   90.57%   +0.13%     
==========================================
  Files         177      181       +4     
  Lines        8937     9248     +311     
  Branches      788      819      +31     
==========================================
+ Hits         8082     8376     +294     
- Misses        855      872      +17
Impacted Files Coverage Δ
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <ø> (ø) ⬆️
...s/opentelemetry-plugin-mongodb-core/src/mongodb.ts 95.34% <100%> (ø)
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <100%> (ø) ⬆️
...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts 97.67% <100%> (ø) ⬆️
...s/opentelemetry-scope-base/src/NoopScopeManager.ts 100% <100%> (ø) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.29% <0%> (-3.71%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
... and 27 more

@mayurkale22
Copy link
Member Author

@vmarchaud Do you know why MongoDB tests are failing (maybe you will be able to find out quickly)?

@vmarchaud
Copy link
Member

@mayurkale22 I will look into this today

@vmarchaud vmarchaud force-pushed the add_missing_codecov branch 2 times, most recently from ad2149f to c699f14 Compare December 10, 2019 13:03
@vmarchaud
Copy link
Member

vmarchaud commented Dec 10, 2019

I was failing because i was checking getCurrentSpan against null to create a span or not, it's weird that the test of #569 which introduced the change where not failing though.
I've also changed the default value of both the AsyncHookScopeManager and NoopScopeManager to return undefined by default so we are more consistent.

EDIT: Might be better rebase commits instead of squash on this one

@mayurkale22 mayurkale22 merged commit 6e22fd5 into open-telemetry:master Dec 10, 2019
@mayurkale22 mayurkale22 deleted the add_missing_codecov branch December 10, 2019 18:41
@mayurkale22
Copy link
Member Author

Thanks @vmarchaud for fixing the build 👍

@mayurkale22 mayurkale22 added the enhancement New feature or request label Dec 10, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Adapt renovate configuration to match core repo and bump API to ensure that peer-dependency gets updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants