Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-metrics-otlp-http): browser OTLPMetricExporter was not passing config to OTLPMetricExporterBase super class #5331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jan 10, 2025

Refs: #5031


This was pointed out in Slack here: https://cloud-native.slack.com/archives/C01NL1GRPQR/p1736535825217819
My PR copies some of the test blocks from "test/node/OTLPMetricExporter.test.ts" (those that were passing
config to OTLPMetricExporter) over to the platform test file.

/cc @pichlermarc

  • I believe we'll want to backport this to the 1.x branch as well.

…assing config to OTLPMetricExporterBase super class

Refs: open-telemetry#5031
@trentm trentm self-assigned this Jan 10, 2025
@trentm trentm requested a review from a team as a code owner January 10, 2025 20:10
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (6864c2f) to head (f890b80).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5331   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files         322      322           
  Lines        8132     8132           
  Branches     1715     1715           
=======================================
  Hits         7690     7690           
  Misses        442      442           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants