test(instrumentation-http): remove tests for deprecated request package #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
commented
Jan 10, 2025
Comment on lines
-38
to
-39
| // Temporarily removed. See https://github.com/open-telemetry/opentelemetry-js/issues/3344 | ||
| // import * as got from 'got'; |
There was a problem hiding this comment.
I have decided that we can make the temporary removal permanent. :) We did not miss the tests for it in the past few years.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5328 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 322 322
Lines 8132 8132
Branches 1715 1715
=======================================
Hits 7690 7690
Misses 442 442 |
trentm
approved these changes
Jan 10, 2025
raphael-theriault-swi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
requestis long deprecated (5+ years), I think we won't get into trouble if we stop testing against it. :D