Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run browser and worker tests on Node.js 22 #5237

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Some devDependencies for browser/webworker tests require Node.js 18+. Since Node.js Version for web tests only affects development, we can bump the version we use for testing browser/workers to Node.js 22. This will unblock some Renovate updates.

How Has This Been Tested?

  • Unit tests

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (a761a8c) to head (1aed2da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5237   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files         315      315           
  Lines        8011     8011           
  Branches     1617     1617           
=======================================
  Hits         7579     7579           
  Misses        432      432           

@pichlermarc pichlermarc marked this pull request as ready for review December 5, 2024 16:22
@pichlermarc pichlermarc requested a review from a team as a code owner December 5, 2024 16:22
@pichlermarc pichlermarc added this pull request to the merge queue Dec 5, 2024
Merged via the queue into open-telemetry:main with commit 0bc4af6 Dec 5, 2024
21 checks passed
@pichlermarc pichlermarc deleted the feat/run-web-test-on-node-22 branch December 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants