chore: add markdown lint check to default lint command #5074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5074 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 317 317
Lines 8195 8195
Branches 1641 1641
==========================================
+ Hits 7643 7644 +1
+ Misses 552 551 -1 |
pichlermarc
reviewed
Oct 17, 2024
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
done |
pichlermarc
approved these changes
Oct 17, 2024
Annosha
pushed a commit
to Annosha/opentelemetry-js
that referenced
this pull request
Oct 19, 2024
…y#5074) Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the lint checks for markdown to the npm run lint command, to align the local command with what is being executed on github workflow.
Without this change the lint was taking 31s, and after it kept at 31s.