Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-metrics): deprecate MeterProvider.addMetricReader() in favor of 'readers' constructor option #4427

Merged
merged 2 commits into from
Jan 24, 2024

fix(changelog): update changelog entry, fix format

b1af2c3
Select commit
Loading
Failed to load commit list.
Merged

feat(sdk-metrics): deprecate MeterProvider.addMetricReader() in favor of 'readers' constructor option #4427

fix(changelog): update changelog entry, fix format
b1af2c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 18, 2024 in 0s

92.21% (+0.01%) compared to 43e598e

View this Pull Request on Codecov

92.21% (+0.01%) compared to 43e598e

Details

Codecov Report

Merging #4427 (b1af2c3) into main (43e598e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4427      +/-   ##
==========================================
+ Coverage   92.19%   92.21%   +0.01%     
==========================================
  Files         336      336              
  Lines        9511     9515       +4     
  Branches     2016     2017       +1     
==========================================
+ Hits         8769     8774       +5     
+ Misses        742      741       -1
Files Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 92.80% <100.00%> (+0.05%) ⬆️
packages/sdk-metrics/src/MeterProvider.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

View more details on Codecov