Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove checks for unsupported versions #4341

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 1, 2023

Fixes #3720

@dyladan dyladan requested a review from a team December 1, 2023 20:37
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #4341 (64dec2a) into next (543f0b4) will increase coverage by 0.01%.
Report is 3 commits behind head on next.
The diff coverage is 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4341      +/-   ##
==========================================
+ Coverage   92.24%   92.26%   +0.01%     
==========================================
  Files         332      332              
  Lines        9437     9434       -3     
  Branches     1999     1995       -4     
==========================================
- Hits         8705     8704       -1     
+ Misses        732      730       -2     
Files Coverage Δ
...erimental/packages/api-logs/src/types/LogRecord.ts 100.00% <ø> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 93.75% <100.00%> (+0.20%) ⬆️
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 94.75% <100.00%> (+0.83%) ⬆️
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 95.23% <100.00%> (ø)
...mental/packages/otlp-transformer/src/logs/index.ts 100.00% <ø> (ø)
experimental/packages/sdk-logs/src/LogRecord.ts 98.05% <100.00%> (+0.07%) ⬆️
...telemetry-sdk-trace-node/src/NodeTracerProvider.ts 100.00% <100.00%> (+5.00%) ⬆️
...kages/otlp-exporter-base/src/platform/node/util.ts 63.80% <0.00%> (-0.35%) ⬇️

... and 2 files with indirect coverage changes

@dyladan dyladan force-pushed the remove-version-checks branch from 1905d58 to 5ea926b Compare December 13, 2023 14:01
@dyladan dyladan merged commit ba00147 into open-telemetry:next Dec 13, 2023
19 checks passed
@dyladan dyladan deleted the remove-version-checks branch December 13, 2023 14:32
trentm added a commit to trentm/opentelemetry-js that referenced this pull request Jan 8, 2025
This re-applies some changes from open-telemetry#4341 that were dropped in
the merge from 'next' back to 'main'.

As a rider, it also corrects the sdk-node/README to indicate
the default context-manager is now the one based on AsyncLocalStorage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants