-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(api): add attributes argument to recordException API (#4071)" #4137
Revert "feat(api): add attributes argument to recordException API (#4071)" #4137
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 326 326
Lines 9305 9299 -6
Branches 1974 1971 -3
=======================================
- Hits 8583 8578 -5
+ Misses 722 721 -1
|
What's the resolution on this? Does it mean that no modification for an existing API is possible, even when it's required by the spec? Or should the downstream dependencies be able to adjust to the API changes? Also, not to complain, but IMHO it'd be helpful to ping the original pull request when it's getting reverted. |
Downstream dependencies will likely need to adjust. The spec is clarifying it here: open-telemetry/opentelemetry-specification#3695. Once the spec PR is merged, we'll proceed accordingly.
Yep, this must've slipped through. Sorry about that. |
Originally introduced in open-telemetry#4071 but reverted in open-telemetry#4137 Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Originally introduced in open-telemetry#4071 but reverted in open-telemetry#4137 Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Which problem is this PR solving?
This reverts commit cd4998a.
Rolls back the breaking change introduced via https://github.com/open-telemetry/opentelemetry-js/releases/tag/api%2Fv1.5.0
I'll open a release PR for API 1.6.0 once this is merged.
Fixes #4136
Type of change