Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(sdk-logs): remove unused rimraf dev dependency #3738

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Looks like I missed one unused rimraf dev dependency in #3737 in sdk-logs. 😓
Removing it in this PR. Sorry about the noise.

Type of change

  • dependencies/internal

@pichlermarc pichlermarc added dependencies Pull requests that update a dependency file internal Skip Changelog labels Apr 18, 2023
@pichlermarc pichlermarc requested a review from a team April 18, 2023 05:01
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #3738 (376aea3) into main (5b9534b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 376aea3 differs from pull request most recent head 4007f84. Consider uploading reports for the commit 4007f84 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3738      +/-   ##
==========================================
+ Coverage   93.44%   93.45%   +0.01%     
==========================================
  Files         290      290              
  Lines        8845     8845              
  Branches     1834     1834              
==========================================
+ Hits         8265     8266       +1     
+ Misses        580      579       -1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc merged commit 1b50f91 into open-telemetry:main Apr 18, 2023
@pichlermarc pichlermarc deleted the deps/sdk-logs branch April 18, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants