Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): added falsy check to make otel core work with browser where webpack config had process as false or null #3617

Merged
merged 8 commits into from
Feb 27, 2023
Merged

fix(core): added falsy check to make otel core work with browser where webpack config had process as false or null #3617

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca6f2fb
fix(process-usage): added falsy check to make it work with browser wi…
ravindra-dyte Feb 16, 2023
9c14bd1
chore(changelog): updated changelog to reflect the change
ravindra-dyte Feb 16, 2023
458953a
test(globalsless-webtraceprovider): added test to ensure globals do n…
ravindra-dyte Feb 16, 2023
a3311b4
chore(changelog): fixed lint failure
ravindra-dyte Feb 16, 2023
acf15e4
style(lint): fixed the lint issues using --fix
ravindra-dyte Feb 16, 2023
560bca3
Update CHANGELOG.md
ravindra-dyte Feb 22, 2023
eb3f38a
Merge branch 'main' into main
dyladan Feb 22, 2023
5492ed1
Merge branch 'main' into main
dyladan Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opentelemetry-core/src/utils/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ export function parseEnvironment(values: RAW_ENVIRONMENT): ENVIRONMENT {
* populating default values.
*/
export function getEnvWithoutDefaults(): ENVIRONMENT {
return typeof process !== 'undefined'
return typeof process !== 'undefined' && process && process.env
Flarna marked this conversation as resolved.
Show resolved Hide resolved
? parseEnvironment(process.env as RAW_ENVIRONMENT)
: parseEnvironment(_globalThis as typeof globalThis & RAW_ENVIRONMENT);
}