Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-metrics): remove accidental export of the SDK Meter class #3243

Merged
merged 3 commits into from
Sep 12, 2022
Merged

chore(sdk-metrics): remove accidental export of the SDK Meter class #3243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
544b228
chore(sdk-metrics): remove accidental export of the SDK Meter class
pichlermarc Sep 9, 2022
5f3348b
fix(changelog): add changelog entry
pichlermarc Sep 9, 2022
52b8436
Merge branch 'main' into chore/remove-accidental-meter-export
pichlermarc Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ All notable changes to experimental packages in this project will be documented
* `NoopObservableMetric`
* `NoopObservableUpDownCounterMetric`
* `NoopUpDownCounterMetric`
* chore(sdk-metrics): remove accidental export of the SDK `Meter` class [#3243](https://github.com/open-telemetry/opentelemetry-js/pull/3243) @pichlermarc

### :rocket: (Enhancement)

Expand Down
4 changes: 0 additions & 4 deletions experimental/packages/opentelemetry-sdk-metrics/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ export {
InstrumentType,
} from './InstrumentDescriptor';

export {
Meter,
} from './Meter';

export {
MeterProvider,
MeterProviderOptions,
Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/opentelemetry-sdk-metrics/test/MeterProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

import * as assert from 'assert';
import { Meter, MeterProvider, InstrumentType, DataPointType } from '../src';
import { MeterProvider, InstrumentType, DataPointType } from '../src';
import {
assertScopeMetrics,
assertMetricData,
Expand All @@ -25,6 +25,7 @@ import {
import { TestMetricReader } from './export/TestMetricReader';
import * as sinon from 'sinon';
import { View } from '../src/view/View';
import { Meter } from '../src/Meter';

describe('MeterProvider', () => {
afterEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-sdk-metrics/test/state/MeterSharedState.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import * as assert from 'assert';
import * as sinon from 'sinon';
import {
Meter,
MeterProvider,
DataPointType,
View,
Expand All @@ -29,6 +28,7 @@ import { assertMetricData, defaultInstrumentationScope, defaultResource, sleep }
import { TestDeltaMetricReader, TestMetricReader } from '../export/TestMetricReader';
import { MeterSharedState } from '../../src/state/MeterSharedState';
import { CollectionResult } from '../../src/export/MetricData';
import { Meter } from '../../src/Meter';

describe('MeterSharedState', () => {
afterEach(() => {
Expand Down