-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove grpc trace exporter dependency on grpc-exporter-base #3100
Conversation
d035aeb
to
c482bcb
Compare
Decided to keep the test for now and apply the change to all exporters at the same time later. |
Codecov Report
@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
- Coverage 93.08% 92.14% -0.94%
==========================================
Files 188 82 -106
Lines 6244 2407 -3837
Branches 1313 522 -791
==========================================
- Hits 5812 2218 -3594
+ Misses 432 189 -243
|
experimental/packages/exporter-trace-otlp-grpc/test/OTLPTraceExporter.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. Also a bit worried about the coverage of the security config code, as touching that code caused the exporters to break the last time around.
experimental/packages/exporter-trace-otlp-grpc/src/OTLPTraceExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/exporter-trace-otlp-grpc/src/OTLPTraceExporter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/exporter-trace-otlp-grpc/test/OTLPTraceExporter.test.ts
Outdated
Show resolved
Hide resolved
Brought that code over from the base package and forgot to bring the tests. good catch |
47e30e3
to
b60ca26
Compare
…js into trace-metric-grpc
@pichlermarc added some tests for the security module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for adding the tests 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but i'm not sure to understand why using the base package were breaking the exports ?
@vmarchaud actually it looks like you're right. A simple test shows that the serviceClient isn't being overwritten like I thought. My initial thought was that because the |
Going to close this since the issue was fixed in a different PR |
Todo in follow-up: