Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InMemoryMetricExporter #3039

Merged
merged 19 commits into from
Jul 26, 2022
Merged

Conversation

weyert
Copy link
Contributor

@weyert weyert commented Jun 15, 2022

Which problem is this PR solving?

Introduces the InMemoryMetricExporter-class which collects metrics and stores it in memory

Fixes #3035 (issue)

Short description of the changes

Adds the InMemoryMetricExporter-class

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #3039 (b065758) into main (1d0eaef) will increase coverage by 0.02%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
+ Coverage   93.09%   93.11%   +0.02%     
==========================================
  Files         188      189       +1     
  Lines        6253     6276      +23     
  Branches     1318     1319       +1     
==========================================
+ Hits         5821     5844      +23     
  Misses        432      432              
Impacted Files Coverage Δ
...-metrics-base/src/export/InMemoryMetricExporter.ts 91.30% <91.30%> (ø)
...s-base/src/export/PeriodicExportingMetricReader.ts 95.65% <0.00%> (+4.34%) ⬆️

Introduces the `InMemoryMetricExporter`-class which collects metrics and stores it in memory
@weyert weyert force-pushed the memory-exporter branch from ea10c05 to 1f208a1 Compare June 15, 2022 23:36
@dyladan dyladan added this to the Metrics GA milestone Jun 16, 2022
@weyert weyert marked this pull request as ready for review June 21, 2022 22:23
@weyert weyert requested a review from a team June 21, 2022 22:23
@weyert
Copy link
Contributor Author

weyert commented Jun 21, 2022

@open-telemetry/javascript-approvers ready to review I think :)

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the churn, but I find some disagreement in the review comments.

@jkwatson
Copy link

@open-telemetry/java-instrumentation-approvers ready to review I think :)

unclear why java folks should be involved here...

@dyladan dyladan removed this from the Metrics GA milestone Jul 13, 2022
@dyladan
Copy link
Member

dyladan commented Jul 25, 2022

@weyert hope you don't mind I went ahead and made the changes so we can get this merged. @legendecas please take another quick look so we can get this merged.

@dyladan dyladan merged commit 5ae0a37 into open-telemetry:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement InMemoryMetricExporter
6 participants