-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add InMemoryMetricExporter #3039
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #3039 +/- ##
==========================================
+ Coverage 93.09% 93.11% +0.02%
==========================================
Files 188 189 +1
Lines 6253 6276 +23
Branches 1318 1319 +1
==========================================
+ Hits 5821 5844 +23
Misses 432 432
|
Introduces the `InMemoryMetricExporter`-class which collects metrics and stores it in memory
experimental/packages/opentelemetry-sdk-metrics-base/src/export/InMemoryMetricExporter.ts
Outdated
Show resolved
Hide resolved
@open-telemetry/javascript-approvers ready to review I think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the churn, but I find some disagreement in the review comments.
experimental/packages/opentelemetry-sdk-metrics-base/src/export/InMemoryMetricExporter.ts
Outdated
Show resolved
Hide resolved
unclear why java folks should be involved here... |
@weyert hope you don't mind I went ahead and made the changes so we can get this merged. @legendecas please take another quick look so we can get this merged. |
Which problem is this PR solving?
Introduces the
InMemoryMetricExporter
-class which collects metrics and stores it in memoryFixes #3035 (issue)
Short description of the changes
Adds the
InMemoryMetricExporter
-classType of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Checklist: