-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otlp-transformer): split otlp-transformer
into multiple packages
#2968
feat(otlp-transformer): split otlp-transformer
into multiple packages
#2968
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2968 +/- ##
==========================================
- Coverage 92.52% 92.52% -0.01%
==========================================
Files 183 183
Lines 5980 5977 -3
Branches 1268 1268
==========================================
- Hits 5533 5530 -3
Misses 447 447
|
Looks like the import type { ReadableSpan } from '@opentelemetry/sdk-trace-base';
import type { ReadableSpan, TimedEvent } from '@opentelemetry/sdk-trace-base'; etc. Can these dependencies be converted to dev-deps and we can keep the current structure of single package for all signals? |
Thanks for catching this @blumamir. I like the approach of converting to dev-dependencies better. 🙂 I opened another PR which does that instead. (#2973) Closing this one. 🙂 |
Which problem is this PR solving?
This PR splits the unreleased
@opentelemetry/otlp-transformer
package along signal lines so that the metrics exporters do not have to depend on@opentelemetry/sdk-trace-base
and the trace exporters do not have to depend on@opentelemetry/sdk-metrics-base
.Type of change
otlp-transformer
has not been released yet.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
addedupdated