Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otlp-transformer): split otlp-transformer into multiple packages #2968

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

This PR splits the unreleased @opentelemetry/otlp-transformer package along signal lines so that the metrics exporters do not have to depend on @opentelemetry/sdk-trace-base and the trace exporters do not have to depend on @opentelemetry/sdk-metrics-base.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • no breaking change as otlp-transformer has not been released yet.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Adapted Unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added updated
  • Documentation has been updated

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #2968 (284a244) into main (22085fc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2968      +/-   ##
==========================================
- Coverage   92.52%   92.52%   -0.01%     
==========================================
  Files         183      183              
  Lines        5980     5977       -3     
  Branches     1268     1268              
==========================================
- Hits         5533     5530       -3     
  Misses        447      447              
Impacted Files Coverage Δ
...er-metrics-otlp-http/src/OTLPMetricExporterBase.ts 44.82% <ø> (ø)
...kages/otlp-transformer-base/src/common/internal.ts 68.18% <ø> (ø)
...ages/otlp-transformer-metrics/src/metrics/index.ts 100.00% <ø> (ø)
...ages/otlp-transformer-metrics/src/metrics/types.ts 100.00% <ø> (ø)
...packages/otlp-transformer-trace/src/trace/types.ts 100.00% <ø> (ø)
.../exporter-trace-otlp-grpc/src/OTLPTraceExporter.ts 100.00% <100.00%> (ø)
...e-otlp-http/src/platform/node/OTLPTraceExporter.ts 100.00% <100.00%> (ø)
...exporter-trace-otlp-proto/src/OTLPTraceExporter.ts 100.00% <100.00%> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
... and 4 more

@blumamir
Copy link
Member

Looks like the otlp-tranformer package currently only uses types from @opentelemetry/sdk-metrics-base and @opentelemetry/sdk-trace-base:

import type { ReadableSpan } from '@opentelemetry/sdk-trace-base';
import type { ReadableSpan, TimedEvent } from '@opentelemetry/sdk-trace-base';

etc.

Can these dependencies be converted to dev-deps and we can keep the current structure of single package for all signals?

@pichlermarc
Copy link
Member Author

Looks like the otlp-tranformer package currently only uses types from @opentelemetry/sdk-metrics-base and @opentelemetry/sdk-trace-base:

import type { ReadableSpan } from '@opentelemetry/sdk-trace-base';
import type { ReadableSpan, TimedEvent } from '@opentelemetry/sdk-trace-base';

etc.

Can these dependencies be converted to dev-deps and we can keep the current structure of single package for all signals?

Thanks for catching this @blumamir. I like the approach of converting to dev-dependencies better. 🙂 I opened another PR which does that instead. (#2973)

Closing this one. 🙂

@pichlermarc pichlermarc deleted the split-otlp-transformer branch July 20, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants