feat(basic-tracer): configure logger

[mayurkale22]

No description provided.

[codecov-io]

Codecov Report

Merging #183 into master will decrease coverage by 0.65%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   93.72%   93.06%   -0.66%     
==========================================
  Files          50       50              
  Lines        1609     1515      -94     
  Branches      100      100              
==========================================
- Hits         1508     1410      -98     
- Misses        101      105       +4

Impacted Files	Coverage Δ
...pentelemetry-basic-tracer/test/BasicTracer.test.ts	100% <100%> (ø)	⬆️
...ages/opentelemetry-basic-tracer/src/BasicTracer.ts	95.83% <100%> (+0.08%)	⬆️
...kages/opentelemetry-basic-tracer/test/Span.test.ts	100% <100%> (ø)	⬆️
packages/opentelemetry-basic-tracer/src/Span.ts	86.66% <40%> (-6.07%)	⬇️

[draffensperger]

Would it make sense to put this at the end and give it a default value, e.g. the NoopLogger? Or do you think it needs to be required with no default?

[rochdev]

I'm not a fan of hiding logs by default. Maybe it could be some kind of ConsoleLogger by default? Then if the user prefers to use their own logger they can change it. The main issue with this approach is that console doesn't have a log level, but that could be configured on the ConsoleLogger with a default of ERROR or WARN.

[draffensperger]

I believe that console itself does implement our Logger interface, and it has an implicit level of DEBUG since it will just print all messages.

So what if we had something like this in some utility file:

export const WARN_LEVEL_CONSOLE_LOGGER = console;

I'm trying to avoid extra layers of wrapping to keep the code minimal if we can, though I'm open to it.

[mayurkale22]

I'm trying to avoid extra layers of wrapping to keep the code minimal if we can, though I'm open to it.

I think the only problem with this is you can't configure the log level. I am in favor of adding ConsoleLogger (may be same as https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-core/src/common/console-logger.ts#L25). Let me know I can it in same PR.

[rochdev]

I'm trying to avoid extra layers of wrapping to keep the code minimal if we can

The wrapper would not do much except add the concept of a log level to console.

[rochdev]

This should probably be discussed in a new issue to unblock this PR. Let's leave it required for now.

[mayurkale22]

Created issue to track #197