Fix NoopTracer with no parent #1605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 164 164
Lines 5024 5025 +1
Branches 1026 1027 +1
=======================================
+ Hits 4581 4582 +1
Misses 443 443
|
vmarchaud
reviewed
Oct 20, 2020
dyladan
approved these changes
Oct 26, 2020
dyladan
approved these changes
Nov 11, 2020
obecny
approved these changes
Nov 11, 2020
mayurkale22
approved these changes
Nov 13, 2020
|
@pauldraper can you please add the test as @vmarchaud suggested? |
|
This seems to be outdated as the SpanOption |
|
|
|
Yes, but it will be never |
|
@Flarna is right closing |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: fix issue with nyc crashing * chore: revert hoist change, make @babel/core nohoist * chore: update @babel/core to test Garbage Collector issue * chore: bump typescripts to 4.4.4 in some package * Revert "chore: bump typescripts to 4.4.4 in some package" This reverts commit 5bf1bfbe433bf614787c0ccca79a40aa644c86b3. * Revert "Revert "chore: bump typescripts to 4.4.4 in some package"" This reverts commit 2877b7e500b629216a66f4b9300e82e3d452ab4f. * Fix cancelled issue --------- Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#1603
Short description of the changes
Check for null parent