Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add status exception on Span.recordException #1490

Closed
wants to merge 11 commits into from
Closed

fix: Add status exception on Span.recordException #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c62fc6f
Merge pull request #1 from open-telemetry/master
jufab Jun 29, 2020
9b8f7c4
Merge pull request #2 from open-telemetry/master
jufab Jul 7, 2020
5d22fb9
Merge pull request #3 from open-telemetry/master
jufab Sep 3, 2020
ef2541e
fix: add status on span during record exception
jufab Sep 3, 2020
5a83740
fix: canonical dep
jufab Sep 3, 2020
b470fcc
fix: proto?
jufab Sep 3, 2020
d9d734f
fix: lint
jufab Sep 3, 2020
a1ac5d8
Merge pull request #4 from open-telemetry/master
jufab Sep 3, 2020
b0720b9
chore: merge
jufab Sep 3, 2020
07f00fa
fix: lint?
jufab Sep 3, 2020
38ac9d2
fix: lint again
jufab Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/opentelemetry-tracing/src/Span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ export class Span implements api.Span, ReadableSpan {
attributes[ExceptionAttribute.MESSAGE]
) {
this.addEvent(ExceptionEventName, attributes as api.Attributes, time);
this.setStatus({ code: api.CanonicalCode.INTERNAL });
} else {
this._logger.warn(`Failed to record an exception ${exception}`);
}
Expand Down
6 changes: 6 additions & 0 deletions packages/opentelemetry-tracing/test/Span.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ describe('Span', () => {
'exception.message': 'boom',
});
assert.ok(event.time[0] > 0);

const status = span.status;
assert.strictEqual(status.code, CanonicalCode.INTERNAL);
});
});

Expand Down Expand Up @@ -432,6 +435,9 @@ describe('Span', () => {
assert.strictEqual(type, 'Error');
assert.strictEqual(message, 'boom');
assert.strictEqual(stacktrace, 'bar');

const status = span.status;
assert.strictEqual(status.code, CanonicalCode.INTERNAL);
});
});
});
Expand Down