feat(backcompat): @types/node backcompat tests #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
commented
Jul 27, 2020
| @@ -13,6 +13,6 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| export function unrefTimer(timer: NodeJS.Timeout): void { | |||
| export function unrefTimer(timer: NodeJS.Timer): void { | |||
There was a problem hiding this comment.
@mayurkale22 Are you aware of anything that would cause this to be an issue? This is the only change needed for this PR to go green.
There was a problem hiding this comment.
The Timer type exists specifically to have compatibility with older versions of node. This should be ok.
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 151 151
Lines 4615 4615
Branches 953 953
=======================================
Hits 4334 4334
Misses 281 281
|
…nto add-backcompat-tests
…nto add-backcompat-tests
obecny
reviewed
Aug 18, 2020
dyladan
reviewed
Aug 18, 2020
…nto add-backcompat-tests
dyladan
approved these changes
Aug 20, 2020
obecny
approved these changes
Aug 26, 2020
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
npm run test:backcompat/backwards-compatability/nodeXYZBackcompat tests will try to
tsca sample node app using different versions of@types/node.