feat: added sum observer metric #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 93.11% 93.16% +0.04%
==========================================
Files 137 139 +2
Lines 3895 3921 +26
Branches 801 804 +3
==========================================
+ Hits 3627 3653 +26
Misses 268 268
|
mayurkale22
reviewed
Jul 11, 2020
Co-authored-by: Mayur Kale <mayurkale@google.com>
obecny
reviewed
Jul 11, 2020
vmarchaud
approved these changes
Jul 11, 2020
dyladan
approved these changes
Jul 13, 2020
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
markwolff
approved these changes
Jul 13, 2020
mayurkale22
approved these changes
Jul 14, 2020
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* feat: added sum observer metric * chore: lint * fix: sum observer now throws away negative values * Update packages/opentelemetry-metrics/src/SumObserverMetric.ts Co-authored-by: Mayur Kale <mayurkale@google.com> * chore: address review comments * Update packages/opentelemetry-metrics/README.md Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> Co-authored-by: Mayur Kale <mayurkale@google.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* feat: added sum observer metric * chore: lint * fix: sum observer now throws away negative values * Update packages/opentelemetry-metrics/src/SumObserverMetric.ts Co-authored-by: Mayur Kale <mayurkale@google.com> * chore: address review comments * Update packages/opentelemetry-metrics/README.md Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> Co-authored-by: Mayur Kale <mayurkale@google.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes