Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update renovate rules #1246

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Conversation

mayurkale22
Copy link
Member

  1. Schedule the update on every Friday morning
  2. Assign to @dyladan, @mayurkale22 and @obecny by default (I am not sure about this).
  3. Skip breaking updates like mocha, got, gcp-metadata, prom-client
  4. Group together all non-major dependencies, see: https://docs.renovatebot.com/configuration-options/#groupname

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1246 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1246   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         126      126           
  Lines        3597     3597           
  Branches      724      724           
=======================================
  Hits         3356     3356           
  Misses        241      241           

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group together all non-major dependencies if this will work as I understand it means we should have much lower number of PR, this is gr8

@mayurkale22
Copy link
Member Author

Group together all non-major dependencies if this will work as I understand it means we should have much lower number of PR, this is gr8

Yeah, that's right. Although it seems nice, there is a small chance of blocking whole PR due to one or more breaking updates. In this case, I believe we need to do some manual intervention. I would like to see how it goes and take it from there.

@dyladan
Copy link
Member

dyladan commented Jun 25, 2020

I think some level of manual intervention is acceptable as long as it doesn't end up blocking every PR. Even if it does end up blocking some PRs, if the intervention isn't much work it might be worth it anyways to keep it down to one a couple PR per week.

@mayurkale22 mayurkale22 merged commit d738a82 into open-telemetry:master Jun 26, 2020
@mayurkale22 mayurkale22 deleted the renovate_rules branch June 26, 2020 22:20
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…#1246)

OTel core experimental packages require a manual update on each release because ^ ranges for 0.x
versions only include new patch versions.

Add a separate renovate config for these packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants