-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecate attribute.component #1220
Merged
mayurkale22
merged 7 commits into
open-telemetry:master
from
markwolff:deprecate-component-attribute
Jun 24, 2020
Merged
refactor: deprecate attribute.component #1220
mayurkale22
merged 7 commits into
open-telemetry:master
from
markwolff:deprecate-component-attribute
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
requested review from
bg451,
dyladan,
legendecas,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
June 18, 2020 21:17
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
- Coverage 93.24% 93.23% -0.01%
==========================================
Files 122 122
Lines 3551 3550 -1
Branches 714 714
==========================================
- Hits 3311 3310 -1
Misses 240 240
|
naseemkullah
approved these changes
Jun 19, 2020
lgtm except for failing browser test edit: I updated the branch in hopes it would magically help browser test pass 🤷♂️ |
dyladan
approved these changes
Jun 19, 2020
I really don't see what changed that makes the browser test fail |
mayurkale22
approved these changes
Jun 19, 2020
Are you planning to apply the same change in |
Please fix the conflicts, looks good to go. |
…nto deprecate-component-attribute
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
component
attribute