Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to remove version-update script during build #808

Closed
mayurkale22 opened this issue Feb 21, 2020 · 8 comments
Closed

proposal to remove version-update script during build #808

mayurkale22 opened this issue Feb 21, 2020 · 8 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@mayurkale22
Copy link
Member

Here is the performance comparison w/ and w/o version-update script during the bootstraping process (npm run bootstrap). I believe version-update script is only needed before publishing the new version, which means no need to run during every build process.

w/ version-update script w/o version-update script
real 2m31.442s real 1m16.299s
user 3m21.372s user 1m45.918s
sys 0m19.538s sys 0m11.541s

Either we can update the RELEASING.md document to run script when we prepare the package for new version or manually change the version.

@mayurkale22 mayurkale22 added the Discussion Issue or PR that needs/is extended discussion. label Feb 21, 2020
@dyladan
Copy link
Member

dyladan commented Feb 21, 2020

Wow that is a much bigger difference than I would have guessed. What OS are you on? Could be an odd filesystem caching issue or even AV software that slows down the process because of file accesses? Maybe we could make it so that the version is checked as part of a custom linting rule rather than as a separate custom script.

@mayurkale22
Copy link
Member Author

macOS Mojave

@dyladan
Copy link
Member

dyladan commented Feb 21, 2020

I'm seeing similar performance impact on catalina. Maybe we should include this as part of a release automation.

@OlivierAlbertini
Copy link
Member

Also for each job on circleci, we generate js files with tsc... I’m wondering if we could cache them in order to be reuse by other jobs. In this way, we compile only once

@obecny
Copy link
Member

obecny commented Feb 27, 2020

I had similar issue with AVG - just try to turn it off and see if you can still see so big difference. If this won't be the case anymore then I guess the issue is the antivirus.

@dyladan
Copy link
Member

dyladan commented Feb 27, 2020

Unfortunately, most of us are on work computers which require AV and backup software. Just disabling it isn't an option for me and I suspect others.

@obecny
Copy link
Member

obecny commented Feb 27, 2020

I didn't mean to disable this forever, just disable that and test if that change anything or not.

@mhennoch
Copy link
Contributor

I think this is fixed, possibly by #1748? @dyladan

@dyladan dyladan closed this as completed May 18, 2021
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

5 participants