-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal to remove version-update script during build #808
Comments
Wow that is a much bigger difference than I would have guessed. What OS are you on? Could be an odd filesystem caching issue or even AV software that slows down the process because of file accesses? Maybe we could make it so that the version is checked as part of a custom linting rule rather than as a separate custom script. |
macOS Mojave |
I'm seeing similar performance impact on catalina. Maybe we should include this as part of a release automation. |
Also for each job on circleci, we generate js files with tsc... I’m wondering if we could cache them in order to be reuse by other jobs. In this way, we compile only once |
I had similar issue with AVG - just try to turn it off and see if you can still see so big difference. If this won't be the case anymore then I guess the issue is the antivirus. |
Unfortunately, most of us are on work computers which require AV and backup software. Just disabling it isn't an option for me and I suspect others. |
I didn't mean to disable this forever, just disable that and test if that change anything or not. |
Here is the performance comparison w/ and w/o
version-update
script during the bootstraping process (npm run bootstrap
). I believeversion-update
script is only needed before publishing the new version, which means no need to run during every build process.Either we can update the RELEASING.md document to run script when we prepare the package for new version or manually change the version.
The text was updated successfully, but these errors were encountered: