Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-node] add HostDetector to the list of default resource detectors #4282

Closed
pichlermarc opened this issue Nov 10, 2023 · 2 comments · Fixed by #4566
Closed

[sdk-node] add HostDetector to the list of default resource detectors #4282

pichlermarc opened this issue Nov 10, 2023 · 2 comments · Fixed by #4566
Assignees
@maryliag
Labels
feature-request pkg:sdk-node

Comments

@pichlermarc
Copy link
Member

HostDetector is not part of the default list of resoruce detectors when intantiating NodeSDK.
I propose we add it to the default list alongside the Environment and Process detectors.
@pichlermarc pichlermarc mentioned this issue Nov 10, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 22, 2024
@maryliag
Copy link
Contributor

as discussed offline, I can take this one 😄

maryliag added a commit to maryliag/opentelemetry-js that referenced this issue Mar 21, 2024
@maryliag
feat(node-sdk): add HostDetector as default resource detector
9a536b5 
Fixes open-telemetry#4282

- Add `HostDetector` to the list od default resource detectors
- Add test to make sure host and process values are being set by default
- Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests
- Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file
maryliag added a commit to maryliag/opentelemetry-js that referenced this issue Mar 21, 2024
@maryliag
feat(node-sdk): add HostDetector as default resource detector
b6bb327 
Fixes open-telemetry#4282

- Add `HostDetector` to the list of default resource detectors
- Add test to make sure host and process values are being set by default
- Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests
- Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file
@maryliag maryliag mentioned this issue Mar 21, 2024
Merged
5 tasks
maryliag added a commit to maryliag/opentelemetry-js that referenced this issue Mar 21, 2024
@maryliag
feat(node-sdk): add HostDetector as default resource detector
4180164 
Fixes open-telemetry#4282

- Add `HostDetector` to the list of default resource detectors
- Add test to make sure host and process values are being set by default
- Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests
- Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file
maryliag added a commit to maryliag/opentelemetry-js that referenced this issue Mar 21, 2024
@maryliag
feat(node-sdk): add HostDetector as default resource detector
f606a0a 
Fixes open-telemetry#4282

- Add `HostDetector` to the list of default resource detectors
- Add test to make sure host and process values are being set by default
- Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests
- Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file
pichlermarc added a commit that referenced this issue Mar 25, 2024
@maryliag @pichlermarc
feat(sdk-node): add HostDetector as default resource detector (#4566)
97af8e6 
* feat(node-sdk): add `HostDetector` as default resource detector

Fixes #4282

- Add `HostDetector` to the list of default resource detectors
- Add test to make sure host and process values are being set by default
- Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests
- Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file

* Update experimental/CHANGELOG.md

* fix lint

remove extra lint causing lint error

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this issue Sep 14, 2024
@maryliag @pichlermarc @Zirak
feat(sdk-node): add HostDetector as default resource detector (open…
d7a66df 
…-telemetry#4566)

* feat(node-sdk): add `HostDetector` as default resource detector

Fixes open-telemetry#4282

- Add `HostDetector` to the list of default resource detectors
- Add test to make sure host and process values are being set by default
- Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests
- Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file

* Update experimental/CHANGELOG.md

* fix lint

remove extra lint causing lint error

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
feature-request pkg:sdk-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk-node): add HostDetector as default resource detector maryliag/opentelemetry-js
2 participants
@maryliag @pichlermarc