Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript Guideline #22

Closed
mayurkale22 opened this issue Jun 10, 2019 · 7 comments
Closed

TypeScript Guideline #22

mayurkale22 opened this issue Jun 10, 2019 · 7 comments

Comments

@mayurkale22
Copy link
Member

Originates from #2 (comment)
@mayurkale22
Copy link
Member Author

@rochdev would you be willing to make a stub in documentation on TypeScript Guideline?

@rochdev
Copy link
Member

rochdev commented Jun 10, 2019

I will take some time this week to do it.

@rochdev
Copy link
Member

rochdev commented Jun 10, 2019

Where should the guideline live?

@mayurkale22
Copy link
Member Author

Where should the guideline live?

I think it can live in root directory (opentelemetry-node), similar to CONTRIBUTING.md. WDYT?

@rochdev
Copy link
Member

rochdev commented Jun 12, 2019

After thinking about this a bit more, I'm not sure a guideline is needed. It should be enough to change the tsconfig.json to disable all features related to transpilation. I will open a separate issue for this. Feel free to close this one.

@rochdev
Copy link
Member

rochdev commented Jun 12, 2019

Opened #27

@mayurkale22
Copy link
Member Author

Closing this one based on #22 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rochdev @mayurkale22