Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginLoader: Check if version and supportedVersions are satisfied #132

Closed
mayurkale22 opened this issue Jul 25, 2019 · 3 comments · Fixed by #237
Closed

PluginLoader: Check if version and supportedVersions are satisfied #132

mayurkale22 opened this issue Jul 25, 2019 · 3 comments · Fixed by #237
Assignees
@OlivierAlbertini
Labels
feature-request

Comments

@mayurkale22
Copy link
Member

Originates from #126 (comment)

Add a function to check whether the given version of the module is supported by the PluginLoader.
@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jul 25, 2019
@kaushikchaubal
Copy link

I am assuming this can't be actioned because the PR (#126) is not merged to master yet

@mayurkale22
Copy link
Member Author

Yes, you're right. I will update this issue when dependent PR gets merged.

@OlivierAlbertini OlivierAlbertini mentioned this issue Aug 3, 2019
Closed
@mayurkale22
Copy link
Member Author

@kaushikchaubal FYI, #126 is merged now. Feel free to work on this issue.

OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 5, 2019
@OlivierAlbertini
feat(plugin): add supportedVersions property
a015821 
Closes open-telemetry#132

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 5, 2019
@OlivierAlbertini
feat(plugin): add supportedVersions property
b499a3c 
Closes open-telemetry#132

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini mentioned this issue Sep 5, 2019
Merged
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 5, 2019
@OlivierAlbertini
feat(plugin): add supportedVersions property
7933018 
Closes open-telemetry#132

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini self-assigned this Sep 5, 2019
mayurkale22 pushed a commit that referenced this issue Sep 7, 2019
@OlivierAlbertini @mayurkale22
feat(plugin): add supportedVersions property (#237)
77a25dc 
* feat(plugin): add supportedVersions property

Closes #132

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add recommendations

from markwolff
from mayurkale22

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 22, 2019
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
@JamesJHPark
Docs: Document the HrTime format (open-telemetry#132)
afd5288
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
@JamesJHPark
Docs: Document the HrTime format (open-telemetry#132)
9539294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierAlbertini OlivierAlbertini

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(plugin): add supportedVersions property VilledeMontreal/opentelemetry-js
3 participants
@kaushikchaubal @OlivierAlbertini @mayurkale22