chore(shim-opentracing): address pr comment

* map UNSET status code explicitly
open-telemetry · May 11, 2021 · ec3a9aa · ec3a9aa
1 parent b4a93ae
commit ec3a9aa
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/packages/opentelemetry-shim-opentracing/src/shim.ts b/packages/opentelemetry-shim-opentracing/src/shim.ts
@@ -313,8 +313,8 @@ export class SpanShim extends opentracing.Span {
   setTag(key: string, value: SpanAttributeValue): this {
     if (key === opentracing.Tags.ERROR) {
       const statusCode = SpanShim._mapErrorTag(value);
-      if (statusCode !== undefined) {
-        this._span.setStatus({ code: statusCode });
+      this._span.setStatus({ code: statusCode });
+      if (statusCode !== SpanStatusCode.UNSET) {
         return this;
       }
     }
@@ -340,9 +340,7 @@ export class SpanShim extends opentracing.Span {
     return this._span;
   }
 
-  private static _mapErrorTag(
-    value: SpanAttributeValue
-  ): SpanStatusCode | undefined {
+  private static _mapErrorTag(value: SpanAttributeValue): SpanStatusCode {
     switch (value) {
       case true:
       case 'true':
@@ -351,7 +349,7 @@ export class SpanShim extends opentracing.Span {
       case 'false':
         return SpanStatusCode.OK;
       default:
-        return;
+        return SpanStatusCode.UNSET;
     }
   }
 }