Apply suggestions from code review

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
open-telemetry · Nov 11, 2024 · d133c01 · d133c01
1 parent 21c4168
commit d133c01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/packages/sdk-metrics/src/state/DeltaMetricProcessor.ts b/packages/sdk-metrics/src/state/DeltaMetricProcessor.ts
@@ -36,7 +36,7 @@ export class DeltaMetricProcessor<T extends Maybe<Accumulation>> {
     private _aggregator: Aggregator<T>,
     aggregationCardinalityLimit?: number
   ) {
-    this._cardinalityLimit = aggregationCardinalityLimit ?? 2000;
+    this._cardinalityLimit = (aggregationCardinalityLimit ?? 2000) - 1;
   }
 
   record(

diff --git a/packages/sdk-metrics/src/view/View.ts b/packages/sdk-metrics/src/view/View.ts
@@ -195,10 +195,7 @@ export class View {
    * @param viewOptions.aggregationCardinalityLimit
    * Alters the metric stream:
    *  Sets a limit on the number of unique attribute combinations (cardinality) that can be aggregated.
-   *  If not provided, the default limit will be used.
-   *
-   * @example <caption>sets the cardinality limit to 1000</caption>
-   * aggregationCardinalityLimit: 1000
+   *  If not provided, the default limit of 2000 will be used.
    *
    * @example
    * // Create a view that changes the Instrument 'my.instrument' to use to an