Merge branch 'main' into feat/add-transformer-entrypoints

.github/workflows/unit-test.yml

@@ -134,39 +134,3 @@ jobs:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
         with:
           verbose: true
-  api-eol-node-test:
-    strategy:
-      fail-fast: false
-      matrix:
-        node_version:
-          - "8"
-          - "10"
-          - "12"
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - uses: actions/setup-node@v4
-        with:
-          cache: 'npm'
-          cache-dependency-path: |
-            package-lock.json
-          node-version: ${{ matrix.node_version }}
-
-      - name: Build
-        working-directory: ./api
-        run: |
-          npm install --ignore-scripts
-          npm install @types/mocha@^7 mocha@^7 ts-loader@^8
-          node ../scripts/version-update.js
-          npx tsc --build tsconfig.json tsconfig.esm.json
-
-      - name: Test
-        working-directory: ./api
-        # running test:eol as node 8 is not supported anymore by the version of nyc we use, as we don't report coverage
-        # for this step we leave it out.
-        # Details: nyc requires istanbul-lib-report, which silently dropped support for Node.js v8 when going from
-        # 3.0.0 to 3.0.1 by requiring make-dir@^4.0.0 to fix https://github.com/advisories/GHSA-c2qf-rxjj-qqgw.
-        # make-dir does not support Node.js v8 anymore.
-        run: npm run test:eol

CHANGELOG.md

@@ -11,7 +11,8 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
 
 ### :boom: Breaking Change
 
-* feat(sdk-metrics)!: drop deprecated `InstrumentDescriptor` type; use `MetricDescriptor` instead [#5277](https://github.com/open-telemetry/opentelemetry-js/pull/5266)
+* feat(sdk-metrics)!: drop deprecated `type` field on `MetricDescriptor` [#5291](https://github.com/open-telemetry/opentelemetry-js/pull/5291) @chancancode
+* feat(sdk-metrics)!: drop deprecated `InstrumentDescriptor` type; use `MetricDescriptor` instead [#5277](https://github.com/open-telemetry/opentelemetry-js/pull/5266) @chancancode
 * feat(sdk-metrics)!: bump minimum version of `@opentelemetry/api` peer dependency to 1.9.0 [#5254](https://github.com/open-telemetry/opentelemetry-js/pull/5254) @chancancode
 * chore(shim-opentracing): replace deprecated SpanAttributes [#4430](https://github.com/open-telemetry/opentelemetry-js/pull/4430) @JamieDanielson
 * chore(otel-core): replace deprecated SpanAttributes [#4408](https://github.com/open-telemetry/opentelemetry-js/pull/4408) @JamieDanielson
@@ -25,6 +26,17 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
 * refactor(sdk-trace-base)!: remove `new Span` constructor in favor of `Tracer.startSpan` API [#5048](https://github.com/open-telemetry/opentelemetry-js/pull/5048) @david-luna
 * refactor(sdk-trace-base)!: remove `BasicTracerProvider.addSpanProcessor` API in favor of constructor options. [#5134](https://github.com/open-telemetry/opentelemetry-js/pull/5134) @david-luna
 * refactor(sdk-trace-base)!: make `resource` property private in `BasicTracerProvider` and remove `getActiveSpanProcessor` API. [#5192](https://github.com/open-telemetry/opentelemetry-js/pull/5192) @david-luna
+* feat(core)!: remove deprecated type `InstrumentationLibrary` [#5308](https://github.com/open-telemetry/opentelemetry-js/pull/5308) @pichlermarc
+  * (user-facing): please use equivalent type `InstrumentationScope` instead
+* feat(sdk-trace-base)!: replace usages fo `InstrumentationLibrary` with `InstrumentationScope` [#5308](https://github.com/open-telemetry/opentelemetry-js/pull/5308) @pichlermarc
+  * (user-facing) rename `Tracer.instrumentationLibrary` -> `Tracer.instrumentationScope`
+  * (user-facing) rename `ReadableSpan.instrumentationLibrary` -> `ReadableSpan.instrumentationScope`
+    * also renames the property in implementations of `ReadableSpan`
+* feat(exporter-jaeger): use `ReadableSpan.instrumentationScope` over `ReadableSpan.instrumentationLibrary` [#5308](https://github.com/open-telemetry/opentelemetry-js/pull/5308) @pichlermarc
+* feat(exporter-zipkin): use `ReadableSpan.instrumentationScope` over `ReadableSpan.instrumentationLibrary` [#5308](https://github.com/open-telemetry/opentelemetry-js/pull/5308) @pichlermarc
+* chore!: update typescript to version `5.0.4` [#5145](https://github.com/open-telemetry/opentelemetry-js/pull/5145) @david-luna
+  * (user-facing) dropped support for `typescript@<5.0.4`
+  * (user-facing) all packages published from this repository will from now on drop support for old versions of `typescript` in minor releases. We will only drop support for versions that are older than 2 years.
 
 ### :rocket: (Enhancement)
 
@@ -39,6 +51,7 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
 * chore: remove checks for unsupported node versions [#4341](https://github.com/open-telemetry/opentelemetry-js/pull/4341) @dyladan
 * refactor(sdk-trace-base): remove `BasicTracerProvider._registeredSpanProcessors` private property. [#5134](https://github.com/open-telemetry/opentelemetry-js/pull/5134) @david-luna
 * refactor(sdk-trace-base): rename `BasicTracerProvider.activeSpanProcessor` private property. [#5211](https://github.com/open-telemetry/opentelemetry-js/pull/5211) @david-luna
+* chore(selenium-tests): remove internal selenium-tests/ package, it wasn't being used @trentm
 
 ## 1.30.0
 

CONTRIBUTING.md

@@ -203,6 +203,15 @@ cd packages/opentelemetry-module-name
 npm run watch
 ```
 
+#### TypeScript version & update policy
+
+TypeScript version used to compile the pacakges is `v5.0.4`. If you plan to use any of the packages from this
+repository to make your own application or package instrumentation make sure to use same version or higher.
+
+<!-- Ref: https://github.com/open-telemetry/opentelemetry-js/pull/5145#issuecomment-2518263890 -->
+As update policy OpenTelemetry JS will follow DefinitelyType's [support policy for TypeScript](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window)
+which sets a support window of 2 years.
+
 ### Running tests
 
 Similar to compilations, tests can be run from the root to run all tests or from a single module to run only the tests for that module.

README.md

@@ -147,6 +147,13 @@ environments. Any support issues that arise from using a browser or runtime that
 
 This minimum support level is subject to change as the project evolves and as the underlying language features evolve.
 
+## TypeScript Support
+
+OpenTelemetry JavaScript is built with TypeScript `v5.0.4`. If you have a TypeScript project (app, library, instrumentation, etc.)
+that depends on it we recomed using same or higher version to compile the project.
+
+OpenTelemetry JavaScript will follows DefinitelyType's [support policy for TypeScript](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window) which sets a support window of 2 years. Support for TypeScript versions older than 2 years will be dropped in minor releases of OpenTelemetry JavaScript.
+
 ## Package Version Compatibility
 
 OpenTelemetry is released as a set of distinct packages in 3 categories: API, stable SDK, and experimental.

api/package.json

@@ -38,7 +38,6 @@
     "lint": "eslint . --ext .ts",
     "test:browser": "karma start --single-run",
     "test": "nyc mocha 'test/**/*.test.ts'",
-    "test:eol": "mocha 'test/**/*.test.ts'",
     "test:webworker": "karma start karma.worker.js --single-run",
     "cycle-check": "dpdm --exit-code circular:1 src/index.ts",
     "version": "node ../scripts/version-update.js",
@@ -98,7 +97,7 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "unionfs": "4.5.4",
     "webpack": "5.96.1"
   },

api/test/common/diag/logLevel.test.ts

@@ -77,7 +77,7 @@ describe('LogLevelFilter DiagLogger', () => {
 
   const levelMap: Array<{
     message: string;
-    level: DiagLogLevel;
+    level: number;
     ignoreFuncs: Array<keyof DiagLogger>;
   }> = [
     { message: 'ALL', level: DiagLogLevel.ALL, ignoreFuncs: [] },

api/test/common/diag/logger.test.ts

@@ -15,7 +15,7 @@
  */
 
 import * as assert from 'assert';
-import sinon = require('sinon');
+import * as sinon from 'sinon';
 import { diag, DiagLogLevel } from '../../../src';
 import { createNoopDiagLogger } from '../../../src/diag/internal/noopLogger';
 import { DiagLogger } from '../../../src/diag/types';

api/test/common/internal/global.test.ts

@@ -15,11 +15,11 @@
  */
 
 import * as assert from 'assert';
+import * as sinon from 'sinon';
 import { getGlobal } from '../../../src/internal/global-utils';
 import { _globalThis } from '../../../src/platform';
 import { NoopContextManager } from '../../../src/context/NoopContextManager';
 import { DiagLogLevel } from '../../../src/diag/types';
-import sinon = require('sinon');
 
 const api1 = require('../../../src') as typeof import('../../../src');
 

examples/opentelemetry-web/package.json

@@ -37,10 +37,10 @@
     "@babel/preset-env": "^7.22.20",
     "babel-loader": "^8.0.6",
     "ts-loader": "^9.2.6",
-    "typescript": "^4.5.2",
+    "typescript": "5.0.4",
     "webpack": "^5.89.0",
     "webpack-cli": "^5.1.4",
-    "webpack-dev-server": "^4.5.0",
+    "webpack-dev-server": "^5.2.0",
     "webpack-merge": "^5.10.0"
   },
   "dependencies": {

experimental/CHANGELOG.md

@@ -7,6 +7,13 @@ All notable changes to experimental packages in this project will be documented
 
 ### :boom: Breaking Change
 
+* feat(exporter-prometheus)!: stop the using `type` field to enforce naming conventions [#5291](https://github.com/open-telemetry/opentelemetry-js/pull/5291) @chancancode
+  * Any non-monotonic sums will now be treated as counters and will therefore include the `_total` suffix.
+* feat(shim-opencenus)!: stop mapping removed Instrument `type` to OpenTelemetry metrics [#5291](https://github.com/open-telemetry/opentelemetry-js/pull/5291) @chancancode
+  * The internal OpenTelemetry data model dropped the concept of instrument type on exported metrics, therefore mapping it is not necessary anymore.
+* feat(instrumentation-fetch)!: passthrough original response to `applyCustomAttributes` hook [#5281](https://github.com/open-telemetry/opentelemetry-js/pull/5281) @chancancode
+  * Previously, the fetch instrumentation code unconditionally clones every `fetch()` response in order to preserve the ability for the `applyCustomAttributes` hook to consume the response body. This is fundamentally unsound, as it forces the browser to buffer and retain the response body until it is fully received and read, which crates unnecessary memory pressure on large or long-running response streams. In extreme cases, this is effectively a memory leak and can cause the browser tab to crash. If your use case for `applyCustomAttributes` requires access to the response body, please chime in on [#5293](https://github.com/open-telemetry/opentelemetry-js/issues/5293).
+
 ### :rocket: (Enhancement)
 
 * feat(oltp-transformer)!: move each serializer to its own entrypoint [#5263](https://github.com/open-telemetry/opentelemetry-js/pull/5263) @pichlermarc

experimental/backwards-compatibility/node14/package.json

@@ -15,7 +15,7 @@
   },
   "devDependencies": {
     "@types/node": "14.18.25",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

experimental/backwards-compatibility/node16/package.json

@@ -15,7 +15,7 @@
   },
   "devDependencies": {
     "@types/node": "16.11.52",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

experimental/packages/api-events/package.json

@@ -79,7 +79,7 @@
     "mocha": "10.8.2",
     "nyc": "15.1.0",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1"
   },
   "homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/api-events",

experimental/packages/api-logs/package.json

@@ -78,7 +78,7 @@
     "mocha": "10.8.2",
     "nyc": "15.1.0",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1"
   },
   "homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/api-logs",

experimental/packages/exporter-logs-otlp-grpc/package.json

@@ -62,7 +62,7 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/exporter-logs-otlp-http/package.json

@@ -92,10 +92,9 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1",
-    "webpack-cli": "5.1.4",
-    "webpack-merge": "5.10.0"
+    "webpack-cli": "5.1.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/exporter-logs-otlp-proto/package.json

@@ -82,10 +82,9 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1",
-    "webpack-cli": "5.1.4",
-    "webpack-merge": "5.10.0"
+    "webpack-cli": "5.1.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/exporter-trace-otlp-grpc/package.json

@@ -59,7 +59,7 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/exporter-trace-otlp-http/package.json

@@ -83,10 +83,9 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1",
-    "webpack-cli": "5.1.4",
-    "webpack-merge": "5.10.0"
+    "webpack-cli": "5.1.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/exporter-trace-otlp-proto/package.json

@@ -81,10 +81,9 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1",
-    "webpack-cli": "5.1.4",
-    "webpack-merge": "5.10.0"
+    "webpack-cli": "5.1.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/opentelemetry-browser-detector/package.json

@@ -72,10 +72,9 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1",
-    "webpack-cli": "5.1.4",
-    "webpack-merge": "5.10.0"
+    "webpack-cli": "5.1.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json

@@ -58,7 +58,7 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/opentelemetry-exporter-metrics-otlp-http/package.json

@@ -83,10 +83,9 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4",
+    "typescript": "5.0.4",
     "webpack": "5.96.1",
-    "webpack-cli": "5.1.4",
-    "webpack-merge": "5.10.0"
+    "webpack-cli": "5.1.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/opentelemetry-exporter-metrics-otlp-proto/package.json

@@ -65,7 +65,7 @@
     "nyc": "15.1.0",
     "sinon": "15.1.2",
     "ts-loader": "9.5.1",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"

experimental/packages/opentelemetry-exporter-prometheus/package.json

@@ -53,7 +53,7 @@
     "mocha": "10.8.2",
     "nyc": "15.1.0",
     "sinon": "15.1.2",
-    "typescript": "4.4.4"
+    "typescript": "5.0.4"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.3.0"