fix: remove test functions out of the class

open-telemetry · Aug 1, 2019 · 37b6575 · 37b6575
1 parent 7394545
commit 37b6575
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/packages/opentelemetry-node-tracer/src/instrumentation/PluginLoader.ts b/packages/opentelemetry-node-tracer/src/instrumentation/PluginLoader.ts
@@ -138,12 +138,12 @@ export class PluginLoader {
     }
     return this;
   }
+}
 
-  /**
-   * Adds a search path for plugin modules. Intended for testing purposes only.
-   * @param searchPath The path to add.
-   */
-  static set searchPathForTest(searchPath: string) {
-    module.paths.push(searchPath);
-  }
+/**
+ * Adds a search path for plugin modules. Intended for testing purposes only.
+ * @param searchPath The path to add.
+ */
+export function searchPathForTest(searchPath: string) {
+  module.paths.push(searchPath);
 }
diff --git a/packages/opentelemetry-node-tracer/test/instrumentation/PluginLoader.test.ts b/packages/opentelemetry-node-tracer/test/instrumentation/PluginLoader.test.ts
@@ -20,6 +20,7 @@ import * as path from 'path';
 import {
   HookState,
   PluginLoader,
+  searchPathForTest,
 } from '../../src/instrumentation/PluginLoader';
 
 const INSTALLED_PLUGINS_PATH = path.join(__dirname, 'node_modules');
@@ -31,7 +32,7 @@ describe('PluginLoader', () => {
 
   before(() => {
     module.paths.push(INSTALLED_PLUGINS_PATH);
-    PluginLoader.searchPathForTest = INSTALLED_PLUGINS_PATH;
+    searchPathForTest(INSTALLED_PLUGINS_PATH);
   });
 
   afterEach(() => {