update browser; webworker tests

- webworkers don't have DOMParser or Document APIs - hard-coding an expected length for Document length is fragile (and varies across platforms)
open-telemetry · May 15, 2024 · 14c9323 · 14c9323
1 parent c995492
commit 14c9323
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/opentelemetry-sdk-trace-web/src/utils.ts b/packages/opentelemetry-sdk-trace-web/src/utils.ts
@@ -221,7 +221,7 @@ export function getFetchBodyLength(...args: Parameters<typeof fetch>) {
 export function getXHRBodyLength(
   body: Document | XMLHttpRequestBodyInit
 ): number {
-  if (body instanceof Document) {
+  if (typeof Document !== 'undefined' && body instanceof Document) {
     return new XMLSerializer().serializeToString(document).length;
   }
   // XMLHttpRequestBodyInit expands to the following:

diff --git a/packages/opentelemetry-sdk-trace-web/test/utils.test.ts b/packages/opentelemetry-sdk-trace-web/test/utils.test.ts
@@ -610,12 +610,17 @@ describe('utils', () => {
 
   describe('getXHRBodyLength', () => {
     it('should compute body length for Document payload', () => {
+      // webworkers don't have DOMParser
+      if (typeof DOMParser === 'undefined') {
+        assert.ok(true);
+        return;
+      }
       const doc = new DOMParser().parseFromString(
         '<html><head><head/><body><p>hello world</p></body>',
         'text/html'
       );
 
-      assert.strictEqual(getXHRBodyLength(doc), 3456); // karma scripts get injected into the html :shakes_fist:
+      assert.ok(getXHRBodyLength(doc) > 0, 'body length is 0');
     });
     it('should compute body length for Blob payload', () => {
       const blob = new Blob(['hello world'], {