fix(resources): fix EnvDetector throwing errors when attribute values…

… contain spaces
open-telemetry · Oct 5, 2022 · 05d3441 · 05d3441
1 parent 1864a9a
commit 05d3441
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,9 @@ All notable changes to this project will be documented in this file.
 
 ### :bug: (Bug Fix)
 
+* fix(resources): fix EnvDetector throwing errors when attribute values contain spaces
+  [#3295](https://github.com/open-telemetry/opentelemetry-js/issues/3295)
+
 ### :books: (Refine Doc)
 
 ### :house: (Internal)

diff --git a/packages/opentelemetry-resources/src/detectors/EnvDetector.ts b/packages/opentelemetry-resources/src/detectors/EnvDetector.ts
@@ -136,7 +136,7 @@ class EnvDetector implements Detector {
   private _isPrintableString(str: string): boolean {
     for (let i = 0; i < str.length; i++) {
       const ch: string = str.charAt(i);
-      if (ch <= ' ' || ch >= '~') {
+      if (ch < ' ' || ch >= '~') {
         return false;
       }
     }

diff --git a/packages/opentelemetry-resources/test/detectors/node/EnvDetector.test.ts b/packages/opentelemetry-resources/test/detectors/node/EnvDetector.test.ts
@@ -26,7 +26,7 @@ describeNode('envDetector() on Node.js', () => {
   describe('with valid env', () => {
     before(() => {
       process.env.OTEL_RESOURCE_ATTRIBUTES =
-        'k8s.pod.name="pod-xyz-123",k8s.cluster.name="c1",k8s.namespace.name="default"';
+        'k8s.pod.name="pod xyz 123",k8s.cluster.name="c1",k8s.namespace.name="default"';
     });
 
     after(() => {
@@ -36,7 +36,7 @@ describeNode('envDetector() on Node.js', () => {
     it('should return resource information from environment variable', async () => {
       const resource: Resource = await envDetector.detect();
       assertK8sResource(resource, {
-        [SemanticResourceAttributes.K8S_POD_NAME]: 'pod-xyz-123',
+        [SemanticResourceAttributes.K8S_POD_NAME]: 'pod xyz 123',
         [SemanticResourceAttributes.K8S_CLUSTER_NAME]: 'c1',
         [SemanticResourceAttributes.K8S_NAMESPACE_NAME]: 'default',
       });