Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to shut cassandra client down if it wasn't initialized #966

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Apr 9, 2022

Which problem is this PR solving?

Tests fail if Cassandra tests which require an external service to be running are not run.

Short description of the changes

Add conditional shut down to avoid running methods on uninitialized var.

It seems like codecov check fails because Cassandra tests covered less than the previous average, thus bringing the avg down.

@rauno56 rauno56 requested a review from a team April 9, 2022 10:05
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #966 (2594a05) into main (cfb0b7a) will decrease coverage by 2.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   95.91%   93.69%   -2.23%     
==========================================
  Files          13       15       +2     
  Lines         856     1062     +206     
  Branches      178      209      +31     
==========================================
+ Hits          821      995     +174     
- Misses         35       67      +32     
Impacted Files Coverage Δ
...y-instrumentation-cassandra/src/instrumentation.ts 80.37% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.91% <0.00%> (ø)

@vmarchaud vmarchaud merged commit 80e855a into open-telemetry:main Apr 11, 2022
@dyladan dyladan mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants