-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-sdk): sns-sqs extract the correct context key from message payload #761
Merged
blumamir
merged 17 commits into
open-telemetry:main
from
habmic:fix/sns-sqs-context-propagation
Nov 30, 2021
Merged
fix(aws-sdk): sns-sqs extract the correct context key from message payload #761
blumamir
merged 17 commits into
open-telemetry:main
from
habmic:fix/sns-sqs-context-propagation
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNS context propagation
github-actions
bot
requested review from
blumamir,
NathanielRN and
willarmiros
November 28, 2021 09:51
Codecov Report
@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 96.87% 96.37% -0.50%
==========================================
Files 11 26 +15
Lines 640 1767 +1127
Branches 126 231 +105
==========================================
+ Hits 620 1703 +1083
- Misses 20 64 +44
|
blumamir
changed the title
Fix/sns sqs context propagation
fix(aws-sdk): sns-sqs extract the correct context key from message payload
Nov 28, 2021
blumamir
approved these changes
Nov 28, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
StringValue
now it will also look forValue