Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release main #696

Merged
merged 1 commit into from
Oct 25, 2021
Merged

chore: release main #696

merged 1 commit into from
Oct 25, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 12, 2021

🤖 I have created a release *beep* *boop*

@opentelemetry/resource-detector-alibaba-cloud: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/resource-detector-aws: 1.0.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.26.0 to ^0.27.0
@opentelemetry/resource-detector-gcp: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/resource-detector-github: 0.26.0

Features

@opentelemetry/auto-instrumentations-node: 0.26.0

Features

  • metapackages: add 1.0 compatibility statement (#709) (25b93bb)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @opentelemetry/instrumentation-dns bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-express bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-graphql bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-ioredis bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-koa bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-mongodb bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-mysql bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-pg bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-redis bumped from ^0.25.0 to ^0.26.0
@opentelemetry/auto-instrumentations-web: 0.26.0

Features

  • metapackages: add 1.0 compatibility statement (#709) (25b93bb)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @opentelemetry/instrumentation-document-load bumped from ^0.25.0 to ^0.26.0
      • @opentelemetry/instrumentation-user-interaction bumped from ^0.25.0 to ^0.26.0
@opentelemetry/browser-extension-autoinjection: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @opentelemetry/instrumentation-document-load bumped from ^0.25.0 to ^0.26.0
@opentelemetry/host-metrics: 0.26.0

Features

@opentelemetry/id-generator-aws-xray: 1.0.0

Features

@opentelemetry/contrib-test-utils: 0.27.0

Features

  • instrumentation-aws-sdk: upstream aws-sdk instrumentation from ext-js (#678) (f5851e7)
  • support API and SDK 1.0 (#706) (096b694)
@opentelemetry/instrumentation-aws-lambda: 0.27.0

Features

Bug Fixes

  • prevent invalid context propagation in lambda functions (#677) (25c0e30)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @opentelemetry/propagator-aws-xray bumped from ^0.24.0 to ^1.0.0
@opentelemetry/instrumentation-aws-sdk: 0.1.0

Features

  • instrumentation-aws-sdk: upstream aws-sdk instrumentation from ext-js (#678) (f5851e7)

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.26.0 to ^0.27.0
@opentelemetry/instrumentation-bunyan: 0.26.0

Features

@opentelemetry/instrumentation-cassandra-driver: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-connect: 0.26.0

Features

@opentelemetry/instrumentation-dns: 0.26.0

Features

@opentelemetry/instrumentation-express: 0.26.0

Features

@opentelemetry/instrumentation-generic-pool: 0.26.0

Features

@opentelemetry/instrumentation-graphql: 0.26.0

Features

@opentelemetry/instrumentation-hapi: 0.26.0

Features

@opentelemetry/instrumentation-ioredis: 0.26.0

Features

Bug Fixes

  • Add support for setConfig in ioredis instrumentation (#689) (314c890)

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-knex: 0.26.0

Features

@opentelemetry/instrumentation-koa: 0.26.0

Features

@opentelemetry/instrumentation-memcached: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-mongodb: 0.26.0

Features

Bug Fixes

  • opentelemetry-instrumentation-mongodb: fix span attributes with unified topology (#663) (aeadca8)

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.26.0 to ^0.27.0
@opentelemetry/instrumentation-mysql: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-mysql2: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-nestjs-core: 0.26.0

Features

@opentelemetry/instrumentation-net: 0.26.0

Features

@opentelemetry/instrumentation-pg: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-pino: 0.26.0

Features

@opentelemetry/instrumentation-redis: 0.26.0

Features

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @opentelemetry/contrib-test-utils bumped from ^0.25.0 to ^0.27.0
@opentelemetry/instrumentation-restify: 0.26.0

Features

Bug Fixes

  • fix restify instrumentation utils that might accept undefined types (#690) (bc11f3d)
@opentelemetry/instrumentation-router: 0.26.0

Features

@opentelemetry/instrumentation-winston: 0.26.0

Features

@opentelemetry/instrumentation-document-load: 0.26.0

Features

@opentelemetry/instrumentation-user-interaction: 0.26.0

Features

Bug Fixes

  • user-interaction: EventTarget is undefined in IE (#627) (5a00bed)
@opentelemetry/plugin-react-load: 0.26.0

Features

@opentelemetry/propagator-aws-xray: 1.0.0

Features

This PR was generated with Release Please. See documentation.

@dyladan dyladan requested a review from a team October 12, 2021 08:13
@github-actions github-actions bot requested a review from obecny October 12, 2021 08:14
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #696 (fa4d0b7) into main (77c215b) will decrease coverage by 1.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   96.87%   95.10%   -1.77%     
==========================================
  Files          11      182     +171     
  Lines         640    13055   +12415     
  Branches      126     1227    +1101     
==========================================
+ Hits          620    12416   +11796     
- Misses         20      639     +619     
Impacted Files Coverage Δ
...de/opentelemetry-instrumentation-hapi/src/types.ts 100.00% <0.00%> (ø)
...telemetry-instrumentation-aws-sdk/test/sqs.test.ts 88.17% <0.00%> (ø)
...ry-instrumentation-aws-sdk/test/aws-sdk-v2.test.ts 100.00% <0.00%> (ø)
...erator-aws-xray/src/internal/xray-id-generation.ts 100.00% <0.00%> (ø)
...lemetry-instrumentation-koa/src/instrumentation.ts 97.01% <0.00%> (ø)
...ode/opentelemetry-instrumentation-dns/src/utils.ts 95.91% <0.00%> (ø)
...ode/opentelemetry-instrumentation-net/src/types.ts 100.00% <0.00%> (ø)
...ry-resource-detector-github/src/detectors/index.ts 100.00% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEcsDetector.ts 100.00% <0.00%> (ø)
...ntelemetry-instrumentation-pg/test/pg-pool.test.ts 91.42% <0.00%> (ø)
... and 161 more

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog seems to miss quite a lot changes (e.g. #695).
As this includes #695 I would assume version 0.26.0 would be a better choice then 0.25.1.

@dyladan dyladan force-pushed the release-please/branches/main branch from ce8d9f7 to d28cb74 Compare October 12, 2021 11:59
@github-actions github-actions bot requested a review from rauno56 October 12, 2021 11:59
@dyladan dyladan force-pushed the release-please/branches/main branch from d28cb74 to 8bffc5a Compare October 12, 2021 17:34
@dyladan dyladan force-pushed the release-please/branches/main branch 2 times, most recently from ae682b2 to 3f1c424 Compare October 15, 2021 13:45
@dyladan
Copy link
Member Author

dyladan commented Oct 18, 2021

@Flarna any change made with chore: conventional commit is not included in the changelog and does not affect the version number of a package. Also, if there are no fix or feat changes, a package will not be released.

When at 0.x.y, semver states that the "patch" part of the version should be treated as "minor" version changes. In general, dependency updates will bump the patch version when we are at 0.x and will bump the minor version after a package goes to 1.x.y.

We can force a different version by using release-as config in the release-please configuration. In the future, we should make sure to use feat: specifier for these dependency updates.

@Flarna
Copy link
Member

Flarna commented Oct 18, 2021

Thanks for the info. I was not aware about this implicit versioning based on commit messages.
I think its important to make everyone aware that commit message is an inportant part in reviews.

@dyladan dyladan force-pushed the release-please/branches/main branch from 3f1c424 to a9b424a Compare October 19, 2021 17:22
@github-actions github-actions bot requested a review from legendecas October 19, 2021 17:22
@obecny
Copy link
Member

obecny commented Oct 19, 2021

@Flarna any change made with chore: conventional commit is not included in the changelog and does not affect the version number of a package. Also, if there are no fix or feat changes, a package will not be released.

When at 0.x.y, semver states that the "patch" part of the version should be treated as "minor" version changes. In general, dependency updates will bump the patch version when we are at 0.x and will bump the minor version after a package goes to 1.x.y.

We can force a different version by using release-as config in the release-please configuration. In the future, we should make sure to use feat: specifier for these dependency updates.

do we have any readme / guidelines how we should be doing and what if we didn't how to fix it ?

@longility
Copy link
Contributor

What is next action? Is there action on someone’s plate to move this forward?

@dyladan dyladan force-pushed the release-please/branches/main branch from a9b424a to db74d22 Compare October 21, 2021 14:32
@dyladan
Copy link
Member Author

dyladan commented Oct 21, 2021

@longility we were waiting for the 1.0 upgrade to be properly changelogged and version incremented appropriately. Seems to have worked now

@dyladan
Copy link
Member Author

dyladan commented Oct 21, 2021

Do we think the auto instrumentations packages should also be incremented to 26?

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-dns is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-dns-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-express is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-express-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-generic-pool is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-generic-pool-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-graphql is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-graphql-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-hapi is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-hapi-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-ioredis is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-ioredis-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-knex is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-knex-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-koa is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-koa-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-memcached is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-memcached-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-mongodb is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-mongodb-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-mysql is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-mysql-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-mysql2 is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-mysql2-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-nestjs-core is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-nestjs-core-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-net is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-net-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-pg is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-pg-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-pino is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-pino-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-redis is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-redis-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-restify is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-restify-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-router is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-router-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-winston is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-winston-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-document-load is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-document-load-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/instrumentation-user-interaction is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-user-interaction-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/plugin-react-load is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/plugin-react-load-v0.26.0 🌻

@dyladan
Copy link
Member Author

dyladan commented Oct 25, 2021

🤖 Release for @opentelemetry/propagator-aws-xray is at https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/propagator-aws-xray-v1.0.0 🌻

@Flarna
Copy link
Member

Flarna commented Oct 25, 2021

Could we tell the bot to post less messages? Such a release is quite spamy..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants