Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(graphql): corrected optional param in Usage section of Readme in opentelemetry-instrumentation-graphql #691

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

saikiran1043
Copy link
Contributor

Which problem is this PR solving?

  • Usage section of Readme.md in opentelemetry-instrumentation-graphql has incorrect optional param allowAttributes. It needs to be allowValues.

Short description of the changes

  • Corrected Usage section of Readme.md in opentelemetry-instrumentation-graphql to include allowValues instead of allowAttributes.

@saikiran1043 saikiran1043 requested a review from a team October 6, 2021 15:27
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 6, 2021

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Kiran Kumar Pennujuru (862dfe9)

@github-actions github-actions bot requested a review from obecny October 6, 2021 15:27
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #691 (265935f) into main (91a221e) will decrease coverage by 2.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   97.75%   95.22%   -2.54%     
==========================================
  Files           7       20      +13     
  Lines         357     1591    +1234     
  Branches       56      217     +161     
==========================================
+ Hits          349     1515    +1166     
- Misses          8       76      +68     
Impacted Files Coverage Δ
...entelemetry-instrumentation-graphql/src/symbols.ts 100.00% <0.00%> (ø)
...metry-instrumentation-graphql/test/graphql.test.ts 100.00% <0.00%> (ø)
...try-instrumentation-graphql/src/instrumentation.ts 92.72% <0.00%> (ø)
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-graphql/test/schema.ts 55.84% <0.00%> (ø)
...entelemetry-instrumentation-graphql/test/helper.ts 100.00% <0.00%> (ø)
...umentation-user-interaction/src/instrumentation.ts 95.48% <0.00%> (ø)
...opentelemetry-instrumentation-graphql/src/utils.ts 95.29% <0.00%> (ø)
...opentelemetry-instrumentation-graphql/src/types.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 96.77% <0.00%> (ø)
... and 3 more

@obecny obecny added the bug Something isn't working label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants