fix(express): construct span names correctly with ignored middleware layers

[seemk]

Which problem is this PR solving?

When middlewares are ignored the final span name is constructed from a concatenation of middleware paths. More here: #451

[codecov]

Codecov Report

Merging #452 (76406ea) into main (550e32c) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   95.23%   95.32%   +0.09%     
==========================================
  Files         133      126       -7     
  Lines        8223     7959     -264     
  Branches      807      774      -33     
==========================================
- Hits         7831     7587     -244     
+ Misses        392      372      -20     

Impacted Files	Coverage Δ
...ges/opentelemetry-host-metrics/test/metric.test.ts
packages/opentelemetry-host-metrics/src/version.ts
packages/opentelemetry-host-metrics/src/metric.ts
...ackages/opentelemetry-host-metrics/src/stats/si.ts
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts
...ges/opentelemetry-host-metrics/src/stats/common.ts
packages/opentelemetry-host-metrics/src/enum.ts
...entelemetry-instrumentation-express/src/express.ts	94.78% <0.00%> (+0.09%)	⬆️
...instrumentation-express/test/custom-config.test.ts	98.85% <0.00%> (+0.51%)	⬆️

[seemk]

Hmm, suddenly unrelated CI errors after merging 5ecccc9

[Flarna]

Most likely a side effect of DefinitelyTyped/DefinitelyTyped#52509
Maybe updating the dependencies of @opentelemetry/instrumentation-hapi solves this.

[dyladan]

build works locally on my machine but seems to complain about hapi/podium only in CI. any ideas? is it building successfully for others locally?

seems to affect all PRs not just this one

edit: just saw your earlier message

[Flarna]

a fix should be included in #455

[dyladan]

Any idea why it works locally?

[Flarna]

most likely because package-lock.json files are lying around and as a result transitive dependencies are not updated.
if I clean everything it fails locally.

[dyladan]

same. i almost regret confirming this because now i can't build locally

[dyladan]

Approving but would like @vmarchaud approval before merge (original plugin author)

[vmarchaud]

@seemk Thanks again for taking the time to do this and being patient with me ahah