Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-ioredis): add requireParentSpan option to config #372

Merged

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Mar 3, 2021

Which problem is this PR solving?

  • fixes ioredis: add requireParent config option #344
  • As discussed in the issue, I've implemented this option so there is no behavior change from how instrumentation is currently operating. This PR does not normalize the requiredParent behavior with other plugins which have different defaults.
  • The new config option name is requiredParentSpan, as suggested by @obecny .

Short description of the changes

  • added requiredParentSpan to instrumentation config, and skip instrumentation only if this config option was set to false.
  • I have added unittests for both cases (true and false). existing tests are verifying the behavior when this config option is unset.
  • I added the new config option and description to the instrumentation README.md

@blumamir blumamir requested a review from a team March 3, 2021 10:13
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #372 (f9fc91a) into main (e3c1359) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          12       12           
  Lines         409      409           
  Branches       44       44           
=======================================
  Hits          384      384           
  Misses         25       25           

@naseemkullah naseemkullah merged commit ff68407 into open-telemetry:main Mar 4, 2021
@obecny obecny added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ioredis: add requireParent config option
4 participants