Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-instrumentations-node)!: disable @opentelemetry/instrumentation-fastify by default #2652

Merged
merged 5 commits into from
Jan 27, 2025
Merged

feat(auto-instrumentations-node)!: disable @opentelemetry/instrumentation-fastify by default #2652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b2e027
feat(auto-instrumentations-node)!: deprecate instrumentation in favor…
pichlermarc Jan 16, 2025
9ec3c64
fixup! feat(auto-instrumentations-node)!: deprecate instrumentation i…
pichlermarc Jan 16, 2025
ae3ddef
test(auto-instrumentations-node): update test to filter out fastify
pichlermarc Jan 17, 2025
3b2d74e
Update metapackages/auto-instrumentations-node/README.md
pichlermarc Jan 23, 2025
f253fdb
Merge branch 'main' into feat/fastify-default-disabled
pichlermarc Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion metapackages/auto-instrumentations-node/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ registerInstrumentations({
- [@opentelemetry/instrumentation-dataloader](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-dataloader)
- [@opentelemetry/instrumentation-dns](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-dns)
- [@opentelemetry/instrumentation-express](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-express)
- [@opentelemetry/instrumentation-fastify](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-fastify)
- [@opentelemetry/instrumentation-fastify](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-fastify) (deprecated, default disabled)
- This component is **deprecated** in favor of the official instrumentation package [`@fastify/otel`](https://www.npmjs.com/package/@fastify/otel), maintained by the Fastify authors.
- Please see [here](https://github.com/fastify/otel?tab=readme-ov-file#usage) for instructions on how to use `@fastify/otel`.
- This component will be removed on June 30, 2025
- [@opentelemetry/instrumentation-fs](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-fs) (default disabled)
- [@opentelemetry/instrumentation-generic-pool](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-generic-pool)
- [@opentelemetry/instrumentation-graphql](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-graphql)
Expand Down
5 changes: 4 additions & 1 deletion metapackages/auto-instrumentations-node/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ const InstrumentationMap = {
'@opentelemetry/instrumentation-winston': WinstonInstrumentation,
};

const defaultExcludedInstrumentations = ['@opentelemetry/instrumentation-fs'];
const defaultExcludedInstrumentations = [
'@opentelemetry/instrumentation-fs',
'@opentelemetry/instrumentation-fastify',
];

// Config types inferred automatically from the first argument of the constructor
type ConfigArg<T> = T extends new (...args: infer U) => unknown ? U[0] : never;
Expand Down
3 changes: 2 additions & 1 deletion metapackages/auto-instrumentations-node/test/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ describe('utils', () => {
).filter(depName => {
return (
depName.startsWith('@opentelemetry/instrumentation-') &&
depName !== '@opentelemetry/instrumentation-fs'
depName !== '@opentelemetry/instrumentation-fs' &&
depName !== '@opentelemetry/instrumentation-fastify'
);
});

Expand Down
Loading